Generating with --no-client flag includes a client

[mackehansson]

The --no-client flag seems to include a http-client.

npx swagger-typescript-api generate -p ./path-to-file.yml -o ./source-location -n MyApi.ts --no-client

Is there perhaps any other flags i need to set together with --no-client? It worked a couple of days ago :)

[takayukioda]

Same thing happened to me.
I guess default value update (#1108) wasn't enough.

It seems no-client option's default value set to false (since codeGenBaseConfig.generateClient is set to true) and that options is flipped again on generateApi

no-client option setting.

swagger-typescript-api/index.ts

Lines 137 to 141 in 1e3b70e

	"no-client": {
	type: "boolean",
	description: "do not generate an API class",
	default: !codeGenBaseConfig.generateClient,
	},

using no-client option to run generate api function.

swagger-typescript-api/index.ts

Line 318 in 1e3b70e

generateClient: !args["no-client"],

[takayukioda]

@smorimoto it's unfortunate, but your fix seems not working as expected.

It seems no-client option is not referenced.
Here's the configuration dump; I embed console.log to bin file and dumped it.

% node_modules/.bin/sta generate --no-client -p openapi.yaml 
{
  _: [],
  client: false,　# <- unknown "client" option.
  p: 'openapi.yaml',
  output: './',
  name: 'Api.ts',
  'default-as-success': false,
  responses: false,
  'union-enums': false,
  'add-readonly': false,
  'route-types': false,
  'no-client': false, # <- no-client is not updated even when "no-client" is set.
  'enum-names-as-values': false,
  'extract-request-params': false,
  'extract-request-body': false,
  'extract-response-body': false,
  'extract-response-error': false,
  'extract-responses': false,
  modular: false,
  js: false,
  'module-name-index': '0',
  'module-name-first-tag': false,
  axios: false,
  'unwrap-response-data': false,
  'disable-throw-on-error': false,
  'single-http-client': false,
  silent: false,
  'default-response': 'void',
  'type-prefix': '',
  'type-suffix': '',
  'clean-output': false,
  'api-class-name': 'Api',
  patch: false,
  debug: false,
  'another-array-type': false,
  'sort-types': false,
  'extract-enums': false,
  'sort-routes': false,
  path: 'openapi.yaml',
  o: './',
  n: 'Api.ts',
  d: false,
  r: false
}

citty has less documents so I'm not so sure, but it seems citty treats options with no- as special case and this might be the cause. (I can see "client" option at the top which isn't defined in your code)
unjs/citty#176 (comment)