Fix CLI argument definitions and client generation logic #1106
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
🦋 Changeset detectedLatest commit: c124f88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses CLI argument definition issues and refines the client generation logic. Key changes include:
- Documenting patch releases via changeset files.
- Updating the "extract-request-params" CLI argument to include an explicit boolean type.
- Adjusting the client generation logic in index.ts to rely solely on the "no-client" argument and explicitly initializing customConfig.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .changeset/easy-paths-check.md | Documents a patch for the updated generateClient logic |
| .changeset/early-kings-marry.md | Documents a patch for the CLI argument type update |
| .changeset/moody-dodos-brake.md | Documents a patch for initializing customConfig in the command run |
| index.ts | Updates CLI argument definitions and refines generateClient logic |
Comments suppressed due to low confidence (1)
index.ts:318
- Ensure that the removal of the 'axios' condition is intentional and that this change has been verified against any existing usage to avoid unintended regressions.
generateClient: !args["no-client"],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1099 (again)