Merge branch '8365/codeRefactoring' into 'main'

#8365 Small code refactoring to make code cleaner

See merge request amc/moodle/moodle-mod_publication!144

Author: Eva Maria Karall

amd/build/alignrows.min.js.map

@@ -1,4 +1,4 @@
-// This file is part of mod_grouptool for Moodle - http://moodle.org/
+// This file is part of mod_publication for Moodle - http://moodle.org/
 //
 // It is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

amd/build/modform.min.js.map

@@ -1,4 +1,4 @@
-// This file is part of mod_grouptool for Moodle - http://moodle.org/
+// This file is part of mod_publication for Moodle - http://moodle.org/
 //
 // It is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by

amd/src/alignrows.js

@@ -98,7 +98,7 @@ class base extends \table_sql {
      * @param string $filter filter for this table
      */
     public function __construct($uniqueid, \publication $publication, $filter) {
-        global $CFG, $OUTPUT;
+        global $CFG;
 
         $this->allfilespage = $publication->get_allfilespage();
         parent::__construct($uniqueid);

amd/src/modform.js

@@ -160,7 +160,6 @@ public function get_approval_status_for_file($file) {
 
         $studentapproved = false;
         $studentdenied = false;
-        $studentpending = false;
         $hint = '';
         if ($obtainstudentapproval == 1) {
             if ($studentapproval == 1) {
@@ -179,7 +178,6 @@ public function get_approval_status_for_file($file) {
                         ['class' => 'd-inline-block']
                     );
                 }
-                $studentpending = true;
                 $hint = get_string('student_pending', 'publication');
             }
         } else {
@@ -191,7 +189,6 @@ public function get_approval_status_for_file($file) {
 
         $teacherapproved = false;
         $teacherdenied = false;
-        $teacherpending = false;
 
         if ($obtainteacherapproval == 1) {
             if ($teacherapproval == 1) {
@@ -201,7 +198,6 @@ public function get_approval_status_for_file($file) {
                 $teacherdenied = true;
                 $hint .= get_string('teacher_rejected', 'publication');
             } else {
-                $teacherpending = true;
                 $hint .= get_string('teacher_pending', 'publication');
             }
         } else {

classes/local/allfilestable/base.php

@@ -60,7 +60,6 @@ public function get_approval_status_for_file($file) {
 
         $studentapproved = false;
         $studentdenied = false;
-        $studentpending = false;
         $hint = '';
 
         if ($obtainstudentapproval == 1) {
@@ -129,7 +128,6 @@ public function get_approval_status_for_file($file) {
 
         $teacherapproved = false;
         $teacherdenied = false;
-        $teacherpending = false;
 
         if ($obtainteacherapproval == 1) {
             if ($teacherapproval == 1) {