Merge pull request #139 from acara-app/refactor/rename-ai-response-action

Refactor: Rename AI Response Action

Author: tuvshinjargal

app/Actions/GenerateAiResponseAction.php …/Actions/ProcessAdvisorMessageAction.phpapp/Actions/GenerateAiResponseAction.php renamed to app/Actions/ProcessAdvisorMessageAction.php app/Actions/GenerateAiResponseAction.php renamed to app/Actions/ProcessAdvisorMessageAction.php

@@ -5,11 +5,11 @@
 namespace App\Actions;
 
 use App\Contracts\Ai\Advisor;
-use App\Contracts\GeneratesAiResponse;
+use App\Contracts\ProcessesAdvisorMessage;
 use App\Models\User;
 use Laravel\Ai\Contracts\ConversationStore;
 
-final readonly class GenerateAiResponseAction implements GeneratesAiResponse
+final readonly class ProcessAdvisorMessageAction implements ProcessesAdvisorMessage
 {
     public function __construct(
         private Advisor $advisor,

app/Contracts/GeneratesAiResponse.php app/Contracts/ProcessesAdvisorMessage.phpapp/Contracts/GeneratesAiResponse.php renamed to app/Contracts/ProcessesAdvisorMessage.php

@@ -4,12 +4,12 @@
 
 namespace App\Contracts;
 
-use App\Actions\GenerateAiResponseAction;
+use App\Actions\ProcessAdvisorMessageAction;
 use App\Models\User;
 use Illuminate\Container\Attributes\Bind;
 
-#[Bind(GenerateAiResponseAction::class)]
-interface GeneratesAiResponse
+#[Bind(ProcessAdvisorMessageAction::class)]
+interface ProcessesAdvisorMessage
 {
     /**
      * @return array{response: string, conversation_id: string}

app/Services/Telegram/TelegramWebhookHandler.php

@@ -5,7 +5,7 @@
 namespace App\Services\Telegram;
 
 use App\Actions\SaveHealthLogAction;
-use App\Contracts\GeneratesAiResponse;
+use App\Contracts\ProcessesAdvisorMessage;
 use App\Contracts\ParsesHealthData;
 use App\DataObjects\HealthLogData;
 use App\Enums\HealthEntryType;
@@ -22,11 +22,12 @@
 final class TelegramWebhookHandler extends WebhookHandler
 {
     public function __construct(
-        private readonly GeneratesAiResponse $generateAiResponse,
+        private readonly ProcessesAdvisorMessage $processAdvisorMessage,
         private readonly TelegramMessageService $telegramMessage,
         private readonly ParsesHealthData $healthDataParser,
         private readonly SaveHealthLogAction $saveHealthLog,
-    ) {}
+    ) {
+    }
 
     public function start(): void
     {
@@ -124,7 +125,7 @@ public function new(): void
             return;
         }
 
-        $conversationId = $this->generateAiResponse->resetConversation($linkedChat->user);
+        $conversationId = $this->processAdvisorMessage->resetConversation($linkedChat->user);
         $linkedChat->update(['conversation_id' => $conversationId]);
 
         $this->chat->message('✨ New conversation started! How can I help you?')->send();
@@ -410,7 +411,7 @@ private function toStringOrNull(mixed $value): ?string
 
     private function generateAndSendResponse(UserTelegramChat $linkedChat, string $message): void
     {
-        $result = $this->generateAiResponse->handle(
+        $result = $this->processAdvisorMessage->handle(
             $linkedChat->user,
             $message,
             $linkedChat->conversation_id,

tests/Feature/Telegram/TelegramWebhookHandlerTest.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-use App\Contracts\GeneratesAiResponse;
+use App\Contracts\ProcessesAdvisorMessage;
 use App\Contracts\ParsesHealthData;
 use App\Enums\HealthEntryType;
 use App\Enums\Sex;
@@ -249,12 +249,12 @@ function sendWebhook(mixed $test, string $text): Illuminate\Testing\TestResponse
             'conversation_id' => 'old-conv-id',
         ]);
 
-        $mock = Mockery::mock(GeneratesAiResponse::class);
+        $mock = Mockery::mock(ProcessesAdvisorMessage::class);
         $mock->shouldReceive('resetConversation')
             ->once()
             ->with(Mockery::on(fn (User $u): bool => $u->id === $user->id))
             ->andReturn('new-conv-id');
-        app()->instance(GeneratesAiResponse::class, $mock);
+        app()->instance(ProcessesAdvisorMessage::class, $mock);
 
         sendWebhook($this, '/new');
 
@@ -271,9 +271,9 @@ function sendWebhook(mixed $test, string $text): Illuminate\Testing\TestResponse
             'telegraph_chat_id' => $this->telegraphChat->id,
         ]);
 
-        $mock = Mockery::mock(GeneratesAiResponse::class);
+        $mock = Mockery::mock(ProcessesAdvisorMessage::class);
         $mock->shouldReceive('resetConversation')->once()->andReturn('reset-conv-id');
-        app()->instance(GeneratesAiResponse::class, $mock);
+        app()->instance(ProcessesAdvisorMessage::class, $mock);
 
         sendWebhook($this, '/reset');
 
@@ -296,7 +296,7 @@ function sendWebhook(mixed $test, string $text): Illuminate\Testing\TestResponse
             'conversation_id' => 'existing-conv',
         ]);
 
-        $mock = Mockery::mock(GeneratesAiResponse::class);
+        $mock = Mockery::mock(ProcessesAdvisorMessage::class);
         $mock->shouldReceive('handle')
             ->once()
             ->with(
@@ -308,7 +308,7 @@ function sendWebhook(mixed $test, string $text): Illuminate\Testing\TestResponse
                 'response' => 'Here are some breakfast suggestions...',
                 'conversation_id' => 'existing-conv',
             ]);
-        app()->instance(GeneratesAiResponse::class, $mock);
+        app()->instance(ProcessesAdvisorMessage::class, $mock);
 
         sendWebhook($this, 'What should I eat for breakfast?');
 
@@ -323,7 +323,7 @@ function sendWebhook(mixed $test, string $text): Illuminate\Testing\TestResponse
             'conversation_id' => null,
         ]);
 
-        $mock = Mockery::mock(GeneratesAiResponse::class);
+        $mock = Mockery::mock(ProcessesAdvisorMessage::class);
         $mock->shouldReceive('handle')
             ->once()
             ->with(
@@ -335,7 +335,7 @@ function sendWebhook(mixed $test, string $text): Illuminate\Testing\TestResponse
                 'response' => 'Welcome!',
                 'conversation_id' => 'first-conv-id',
             ]);
-        app()->instance(GeneratesAiResponse::class, $mock);
+        app()->instance(ProcessesAdvisorMessage::class, $mock);
 
         sendWebhook($this, 'Hello!');
 
@@ -350,14 +350,14 @@ function sendWebhook(mixed $test, string $text): Illuminate\Testing\TestResponse
             'conversation_id' => 'existing-conv',
         ]);
 
-        $mock = Mockery::mock(GeneratesAiResponse::class);
+        $mock = Mockery::mock(ProcessesAdvisorMessage::class);
         $mock->shouldReceive('handle')
             ->once()
             ->andReturn([
                 'response' => 'Response',
                 'conversation_id' => 'some-new-conv',
             ]);
-        app()->instance(GeneratesAiResponse::class, $mock);
+        app()->instance(ProcessesAdvisorMessage::class, $mock);
 
         sendWebhook($this, 'Follow-up message');
 
@@ -371,10 +371,10 @@ function sendWebhook(mixed $test, string $text): Illuminate\Testing\TestResponse
             'telegraph_chat_id' => $this->telegraphChat->id,
         ]);
 
-        $mock = Mockery::mock(GeneratesAiResponse::class);
+        $mock = Mockery::mock(ProcessesAdvisorMessage::class);
         $mock->shouldReceive('handle')
             ->andThrow(new Exception('AI service unavailable'));
-        app()->instance(GeneratesAiResponse::class, $mock);
+        app()->instance(ProcessesAdvisorMessage::class, $mock);
 
         sendWebhook($this, 'Hello');
 

…Actions/GenerateAiResponseActionTest.php …ions/ProcessAdvisorMessageActionTest.phptests/Unit/Actions/GenerateAiResponseActionTest.php renamed to tests/Unit/Actions/ProcessAdvisorMessageActionTest.php tests/Unit/Actions/GenerateAiResponseActionTest.php renamed to tests/Unit/Actions/ProcessAdvisorMessageActionTest.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-use App\Actions\GenerateAiResponseAction;
+use App\Actions\ProcessAdvisorMessageAction;
 use App\Ai\Agents\NutritionAdvisor;
 use App\Models\User;
 use Laravel\Ai\Contracts\ConversationStore;
@@ -23,7 +23,7 @@
         ->once()
         ->andReturn('conv-123');
 
-    $action = new GenerateAiResponseAction(
+    $action = new ProcessAdvisorMessageAction(
         resolve(NutritionAdvisor::class),
         $conversationStore,
     );
@@ -39,7 +39,7 @@
 it('uses existing conversation when provided', function (): void {
     NutritionAdvisor::fake(['Continuing...']);
 
-    $action = new GenerateAiResponseAction(
+    $action = new ProcessAdvisorMessageAction(
         resolve(NutritionAdvisor::class),
         resolve(ConversationStore::class),
     );
@@ -61,7 +61,7 @@
         ->once()
         ->andReturn('latest-conv');
 
-    $action = new GenerateAiResponseAction(
+    $action = new ProcessAdvisorMessageAction(
         resolve(NutritionAdvisor::class),
         $conversationStore,
     );
@@ -81,7 +81,7 @@
         ->once()
         ->andReturn('new-conv');
 
-    $action = new GenerateAiResponseAction(
+    $action = new ProcessAdvisorMessageAction(
         resolve(NutritionAdvisor::class),
         $conversationStore,
     );