Skip to content

Commit 97723fc

Browse files
committed
[Tests] Add more templated types for LLDB to resolve
1 parent 77472c7 commit 97723fc

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

lldb/unittests/DIL/DILTests.cpp

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2084,21 +2084,10 @@ TEST_F(EvalTest, TestTemplateTypes) {
20842084
EXPECT_THAT(Eval("(::ns::T_1<" + arg + ">::myint)1.1"), IsEqual("1"));
20852085
EXPECT_THAT(Eval("(ns::T_1<T_1<" + arg + "> >::myint)1.1"), IsEqual("1"));
20862086
EXPECT_THAT(Eval("(::ns::T_1<T_1<" + arg + "> >::myint)1.1"), IsEqual("1"));
2087-
}
2088-
2089-
EXPECT_THAT(
2090-
Eval("(ns::T_1<ns::T_1<int> >::myint)1.1"),
2091-
XFail(IsError(
2092-
"use of undeclared identifier 'ns::T_1<ns::T_1<int> >::myint'")));
2093-
EXPECT_THAT(
2094-
Eval("(::ns::T_1<ns::T_1<int> >::myint)1.1"),
2095-
XFail(IsError(
2096-
"use of undeclared identifier '::ns::T_1<ns::T_1<int> >::myint'")));
2097-
for (std::string arg : {"int*", "int**", "int&", "int*&"}) {
20982087
EXPECT_THAT(Eval("(ns::T_1<ns::T_1<" + arg + "> >::myint)1.1"),
2099-
IsError("use of undeclared identifier 'ns::T_1'"));
2088+
IsEqual("1"));
21002089
EXPECT_THAT(Eval("(::ns::T_1<ns::T_1<" + arg + "> >::myint)1.1"),
2101-
IsError("use of undeclared identifier '::ns::T_1'"));
2090+
IsEqual("1"));
21022091
}
21032092

21042093
EXPECT_THAT(Eval("(T_2<int, char>::myint)1.1f"), IsEqual("1.10000002"));

lldb/unittests/DIL/Inputs/test_binary.cc

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -727,7 +727,15 @@ static void TestTemplateTypes() {
727727
{ T_2<T_1<T_1<int>>, T_1<char>> _; }
728728

729729
{ ns::T_1<int> _; }
730+
{ ns::T_1<int *> _; }
731+
{ ns::T_1<int **> _; }
732+
{ ns::T_1<int &> _(i); }
733+
{ ns::T_1<int *&> _(p); }
730734
{ ns::T_1<ns::T_1<int>> _; }
735+
{ ns::T_1<ns::T_1<int *>> _; }
736+
{ ns::T_1<ns::T_1<int **>> _; }
737+
{ ns::T_1<ns::T_1<int &>> _(i); }
738+
{ ns::T_1<ns::T_1<int *&>> _(p); }
731739

732740
{ T_1<int>::myint _ = 0; }
733741
{ T_1<int *>::myint _ = 0; }

0 commit comments

Comments
 (0)