Fix unit tests with an extern variable

Author: kuilpd

lldb/unittests/DIL/DILTests.cpp

@@ -1100,8 +1100,8 @@ TEST_F(EvalTest, TestGlobalVariableLookup) {
   EXPECT_THAT(Eval("::globalRef"), IsEqual("-559038737"));
 
   EXPECT_THAT(Eval("externGlobalVar"),
-              XFail(IsEqual("12648430"))); // 0x00C0FFEE
-  EXPECT_THAT(Eval("::externGlobalVar"), XFail(IsEqual("12648430")));
+              IsEqual("12648430")); // 0x00C0FFEE
+  EXPECT_THAT(Eval("::externGlobalVar"), IsEqual("12648430"));
 
   EXPECT_THAT(Eval("ns::globalVar"), IsEqual("13"));
   EXPECT_THAT(Eval("ns::globalPtr"), IsOk());
@@ -1155,7 +1155,7 @@ TEST_F(EvalTest, TestAddressOf) {
   EXPECT_THAT(Eval("&p != &my_pr"), IsEqual("false"));
 
   EXPECT_THAT(Eval("&globalVar"), IsOk());
-  EXPECT_THAT(Eval("&externGlobalVar"), XFail(IsOk()));
+  EXPECT_THAT(Eval("&externGlobalVar"), IsOk());
   EXPECT_THAT(Eval("&s_str"), IsOk());
   EXPECT_THAT(Eval("&param"), IsOk());
 

lldb/unittests/DIL/Inputs/CMakeLists.txt

@@ -20,12 +20,13 @@ if ("libcxx" IN_LIST LLVM_ENABLE_RUNTIMES)
   add_custom_command(
     OUTPUT test_binary.bin
     COMMAND $<TARGET_FILE:clang> ${CMAKE_CURRENT_SOURCE_DIR}/test_binary.cc
+            ${CMAKE_CURRENT_SOURCE_DIR}/test_library.cc
             -O0 -g -std=c++17 -fuse-ld=lld -B$<TARGET_FILE:lld>
             -nostdlib++ -nostdinc++ -cxx-isystem ${LIBCXX_GENERATED_INCLUDE_DIR}
             ${INCLUDE_TARGET_DIR_OPTION}
             -L${LIBCXX_LIBRARY_DIR} -Wl,-rpath,${LIBCXX_LIBRARY_DIR} -lc++
             -o ${EXE_PATH}/Inputs/test_binary.bin
-    DEPENDS test_binary.cc clang lld
+    DEPENDS test_binary.cc test_library.cc clang lld
   )
   add_custom_target(test_binary
     DEPENDS test_binary.bin