Add unit tests from lldb-eval (#5)

Add unit tests ported from lldb-eval.
In order for the test suite to pass without errors, some tests were adjusted:
* XFailed tests: caused by bugs currently present in DIL
* Skipped tests under `GTEST_SKIP`: critical bugs that cause the test suite to crash
* `DISABLED_` tests for unimplemented features (scoped evaluation, evaluation with context, separate parsing, UTF-8 support)

Author: kuilpd

lldb/include/lldb/API/SBFrame.h

@@ -122,6 +122,9 @@ class LLDB_API SBFrame {
   lldb::SBValue EvaluateExpression(const char *expr,
                                    const SBExpressionOptions &options);
 
+  lldb::SBValue EvaluateExpressionViaDIL(const char *expr,
+                                         lldb::DynamicValueType use_dynamic);
+
   /// Language plugins can use this API to report language-specific
   /// runtime information about this compile unit, such as additional
   /// language version details or feature flags.

lldb/source/API/SBFrame.cpp

@@ -1155,6 +1155,82 @@ lldb::SBValue SBFrame::EvaluateExpression(const char *expr,
   return expr_result;
 }
 
+lldb::SBValue
+SBFrame::EvaluateExpressionViaDIL(const char *expr,
+                                  lldb::DynamicValueType use_dynamic) {
+  LLDB_INSTRUMENT_VA(this, expr);
+  Log *expr_log = GetLog(LLDBLog::Expressions);
+  SBValue expr_result;
+  if (expr == nullptr || expr[0] == '\0') {
+    return expr_result;
+  }
+  ValueObjectSP expr_value_sp;
+  std::unique_lock<std::recursive_mutex> lock;
+  ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
+  StackFrame *frame = nullptr;
+  Target *target = exe_ctx.GetTargetPtr();
+  Process *process = exe_ctx.GetProcessPtr();
+  SBExpressionOptions options;
+  options.SetFetchDynamicValue(use_dynamic);
+  if (target && process) {
+    Process::StopLocker stop_locker;
+    if (stop_locker.TryLock(&process->GetRunLock())) {
+      frame = exe_ctx.GetFramePtr();
+      if (frame) {
+        std::unique_ptr<llvm::PrettyStackTraceFormat> stack_trace;
+        if (target->GetDisplayExpressionsInCrashlogs()) {
+          StreamString frame_description;
+          frame->DumpUsingSettingsFormat(&frame_description);
+          stack_trace = std::make_unique<llvm::PrettyStackTraceFormat>(
+              "SBFrame::EvaluateExpressionViaDIL (expr = \"%s\", "
+              "fetch_dynamic_value "
+              "= %u) %s",
+              expr, options.GetFetchDynamicValue(),
+              frame_description.GetData());
+        }
+        VariableSP var_sp;
+        Status error;
+        expr_value_sp =
+            frame->GetValueForVariableExpressionPath( // DIL in ths branch
+                expr, use_dynamic,
+                StackFrame::eExpressionPathOptionCheckPtrVsMember |
+                    StackFrame::eExpressionPathOptionsAllowDirectIVarAccess,
+                var_sp, error);
+        if (!error.Success()) {
+          expr_value_sp =
+              ValueObjectConstResult::Create(nullptr, std::move(error));
+          expr_result.SetSP(expr_value_sp, false);
+        } else {
+          expr_result.SetSP(expr_value_sp, options.GetFetchDynamicValue());
+        }
+      }
+    } else {
+      Status error;
+      error = Status::FromErrorString("can't evaluate expressions when the "
+                                      "process is running.");
+      expr_value_sp = ValueObjectConstResult::Create(nullptr, std::move(error));
+      expr_result.SetSP(expr_value_sp, false);
+    }
+  } else {
+    Status error;
+    error = Status::FromErrorString("sbframe object is not valid.");
+    expr_value_sp = ValueObjectConstResult::Create(nullptr, std::move(error));
+    expr_result.SetSP(expr_value_sp, false);
+  }
+  if (expr_result.GetError().Success())
+    LLDB_LOGF(expr_log,
+              "** [SBFrame::EvaluateExpressionViaDIL] Expression result is "
+              "%s, summary %s **",
+              expr_result.GetValue(), expr_result.GetSummary());
+  else
+    LLDB_LOGF(
+        expr_log,
+        "** [SBFrame::EvaluateExpressionViaDIL] Expression evaluation failed: "
+        "%s **",
+        expr_result.GetError().GetCString());
+  return expr_result;
+}
+
 SBStructuredData SBFrame::GetLanguageSpecificData() const {
   LLDB_INSTRUMENT_VA(this);
 

lldb/unittests/CMakeLists.txt

@@ -55,6 +55,7 @@ add_subdirectory(Breakpoint)
 add_subdirectory(Callback)
 add_subdirectory(Core)
 add_subdirectory(DataFormatter)
+add_subdirectory(DIL)
 add_subdirectory(Disassembler)
 add_subdirectory(Editline)
 add_subdirectory(Expression)

lldb/unittests/DIL/CMakeLists.txt

@@ -0,0 +1,13 @@
+add_lldb_unittest(DILTests
+  DILTests.cpp
+  Runner.cpp
+
+  LINK_LIBS
+    liblldb
+    lldbUtilityHelpers
+    LLVMTestingSupport
+  )
+add_subdirectory(Inputs)
+add_dependencies(DILTests test_binary)
+
+add_unittest_inputs(DILTests "test_binary.cc")