[clang] Make the CGPointerAuthInfo parameter to the general CGCallee constructor mandatory.

Author: ahmedbougacha

clang/lib/CodeGen/CGCall.h

@@ -109,7 +109,7 @@ class CGCallee {
   /// Construct a callee.  Call this constructor directly when this
   /// isn't a direct call.
   CGCallee(const CGCalleeInfo &abstractInfo, llvm::Value *functionPtr,
-           const CGPointerAuthInfo &pointerAuthInfo = /*FIXME*/ CGPointerAuthInfo())
+           const CGPointerAuthInfo &pointerAuthInfo)
       : KindOrFunctionPointer(
             SpecialKind(reinterpret_cast<uintptr_t>(functionPtr))) {
     OrdinaryInfo.AbstractInfo = abstractInfo;

clang/lib/CodeGen/CGObjCGNU.cpp

@@ -2625,7 +2625,8 @@ CGObjCGNU::GenerateMessageSendSuper(CodeGenFunction &CGF,
           llvm::Type::getInt1Ty(VMContext), IsClassMessage))};
   llvm::MDNode *node = llvm::MDNode::get(VMContext, impMD);
 
-  CGCallee callee(CGCalleeInfo(), imp);
+  CGPointerAuthInfo pointerAuth; // TODO
+  CGCallee callee(CGCalleeInfo(), imp, pointerAuth);
 
   llvm::CallBase *call;
   RValue msgRet = CGF.EmitCall(MSI.CallInfo, callee, Return, ActualArgs, &call);
@@ -2806,7 +2807,8 @@ CGObjCGNU::GenerateMessageSend(CodeGenFunction &CGF,
   imp = EnforceType(Builder, imp, MSI.MessengerType);
 
   llvm::CallBase *call;
-  CGCallee callee(CGCalleeInfo(), imp);
+  CGPointerAuthInfo pointerAuth; // TODO
+  CGCallee callee(CGCalleeInfo(), imp, pointerAuth);
   RValue msgRet = CGF.EmitCall(MSI.CallInfo, callee, Return, ActualArgs, &call);
   call->setMetadata(msgSendMDKind, node);
 

clang/lib/CodeGen/MicrosoftCXXABI.cpp

@@ -1977,7 +1977,7 @@ CGCallee MicrosoftCXXABI::getVirtualFunctionPointer(CodeGenFunction &CGF,
     VFunc = Builder.CreateAlignedLoad(Ty, VFuncPtr, CGF.getPointerAlign());
   }
 
-  CGCallee Callee(GD, VFunc);
+  CGCallee Callee(GD, VFunc, /*unsigned*/ CGPointerAuthInfo());
   return Callee;
 }
 
@@ -3559,7 +3559,7 @@ CGCallee MicrosoftCXXABI::EmitLoadOfMemberFunctionPointer(
 
   FunctionPointer =
     Builder.CreateBitCast(FunctionPointer, FTy->getPointerTo());
-  CGCallee Callee(FPT, FunctionPointer);
+  CGCallee Callee(FPT, FunctionPointer, /*unsigned*/ CGPointerAuthInfo());
   return Callee;
 }