feat(cicero-core): fix windows path normalization and increase test c… (#863)

* feat(cicero-core): fix windows path normalization and increase test coverage to 91%

Signed-off-by: Rahul-R79 <rahul.devworks@gmail.com>

* chore(cicero-core): address PR feedback, fix linting

Signed-off-by: Rahul-R79 <rahul.devworks@gmail.com>

---------

Signed-off-by: Rahul-R79 <rahul.devworks@gmail.com>

Author: Rahul-R79

packages/cicero-core/package.json

@@ -115,10 +115,10 @@
     ],
     "all": true,
     "check-coverage": true,
-    "statements": 82,
-    "branches": 78,
-    "functions": 76,
-    "lines": 83
+    "statements": 91,
+    "branches": 81,
+    "functions": 89,
+    "lines": 91
   },
   "gitHead": "514fd02f46752e018aedb77e1716a212ef4a59e5"
 }

packages/cicero-core/src/templateloader.js

@@ -403,7 +403,8 @@ class TemplateLoader {
                 }
             }
             else {
-                if (regex.test(res)) {
+                const slashPath = slash(res);
+                if (regex.test(slashPath)) {
                     return {
                         name: res,
                         contents: await TemplateLoader.loadFileContents(path, res, false, true)

packages/cicero-core/test/core_classes.js

@@ -0,0 +1,55 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+'use strict';
+
+const Argument = require('../src/argument');
+const ArgumentType = require('../src/argumenttype');
+const CiceroFunction = require('../src/function');
+const Contract = require('../src/contract');
+
+const chai = require('chai');
+chai.should();
+chai.use(require('chai-as-promised'));
+
+describe('Core Classes', () => {
+    describe('Argument', () => {
+        it('should create an Argument', () => {
+            const arg = new Argument('name', 'type');
+            arg.getName().should.equal('name');
+            arg.getType().should.equal('type');
+        });
+    });
+
+    describe('ArgumentType', () => {
+        it('should create an ArgumentType', () => {
+            const type = new ArgumentType('type');
+            type.getName().should.equal('type');
+        });
+    });
+
+    describe('Function', () => {
+        it('should create a Function', () => {
+            const func = new CiceroFunction('name', []);
+            func.getName().should.equal('name');
+            func.getArguments().should.deep.equal([]);
+        });
+    });
+
+    describe('Contract', () => {
+        it('should have a constructor', () => {
+            Contract.should.not.be.null;
+        });
+    });
+});

packages/cicero-core/test/loaders/defaultarchiveloader.js

@@ -0,0 +1,35 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+'use strict';
+
+const DefaultArchiveLoader = require('../../src/loaders/defaultarchiveloader');
+
+const chai = require('chai');
+chai.should();
+chai.use(require('chai-as-promised'));
+
+describe('DefaultArchiveLoader', () => {
+    let loader;
+
+    beforeEach(() => {
+        loader = new DefaultArchiveLoader();
+    });
+
+    describe('#constructor', () => {
+        it('should create a DefaultArchiveLoader', () => {
+            loader.should.not.be.null;
+        });
+    });
+});

packages/cicero-core/test/loaders/githubarchiveloader.js

@@ -0,0 +1,64 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+'use strict';
+
+const GitHubArchiveLoader = require('../../src/loaders/githubarchiveloader');
+const mock = require('mock-require');
+
+const chai = require('chai');
+chai.should();
+chai.use(require('chai-as-promised'));
+
+describe('GitHubArchiveLoader', () => {
+    let loader;
+
+    beforeEach(() => {
+        loader = new GitHubArchiveLoader();
+    });
+
+    describe('#accepts', () => {
+        it('should accept a github URL', () => {
+            loader.accepts('github://accordproject/githubarchiveloader').should
+                .be.true;
+        });
+
+        it('should not accept a non-github URL', () => {
+            loader.accepts('http://accordproject/githubarchiveloader').should.be
+                .false;
+        });
+    });
+
+    describe('#load', () => {
+        it('should load an archive from github', async () => {
+            const axiosMock = (request) => {
+                return Promise.resolve({ data: Buffer.from('test') });
+            };
+            mock('axios', axiosMock);
+            try {
+                mock.reRequire('../../src/loaders/httparchiveloader');
+                const MockedLoader = mock.reRequire(
+                    '../../src/loaders/githubarchiveloader',
+                );
+                const mockedLoader = new MockedLoader();
+                const buffer = await mockedLoader.load(
+                    'github://accordproject/githubarchiveloader',
+                );
+                buffer.toString().should.equal('test');
+            } finally {
+                mock.stop('axios');
+            }
+        });
+    });
+});

packages/cicero-core/test/templatesaver.js

@@ -0,0 +1,68 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+'use strict';
+
+const JSZip = require('jszip');
+const TemplateSaver = require('../src/templatesaver');
+const Template = require('../src/template');
+
+const chai = require('chai');
+const expect = chai.expect;
+chai.should();
+chai.use(require('chai-as-promised'));
+
+describe('TemplateSaver', () => {
+    describe('#toArchive', () => {
+        it('should save a template with a signature', async () => {
+            const template = await Template.fromDirectory(
+                './test/data/latedeliveryandpenalty',
+            );
+            template.authorSignature = {
+                templateHash: 'hash',
+                timestamp: Date.now(),
+                signatoryCert: 'cert',
+                signature: 'sig',
+            };
+            const buffer = await TemplateSaver.toArchive(template);
+            buffer.should.not.be.null;
+
+            // Verify the signature.json exists in the archive
+            const zip = await JSZip.loadAsync(buffer);
+            const sigFile = zip.file('signature.json');
+            expect(sigFile).to.not.be.null;
+
+            const sigString = await sigFile.async('string');
+            const sig = JSON.parse(sigString);
+            sig.templateSignature.signature.should.equal('sig');
+        });
+
+        it('should save a template with multiple locales', async () => {
+            const template = await Template.fromDirectory(
+                './test/data/latedeliveryandpenalty',
+            );
+            template.getMetadata().getSamples().fr = 'Bonjour';
+            const buffer = await TemplateSaver.toArchive(template);
+            buffer.should.not.be.null;
+
+            // Verify the French sample text exists in the archive
+            const zip = await JSZip.loadAsync(buffer);
+            const sampleFile = zip.file('text/sample_fr.md');
+            expect(sampleFile).to.not.be.null;
+
+            const content = await sampleFile.async('string');
+            content.should.equal('Bonjour');
+        });
+    });
+});