Skip to content

Commit 433c114

Browse files
committed
generate real tokens
1 parent 7ef5de4 commit 433c114

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

packages/server/src/accounts-server.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
ImpersonateReturnType,
1313
HookListener,
1414
} from '@accounts/common';
15-
import { generateAccessToken, generateRefreshToken } from './tokens';
15+
import { generateAccessToken, generateRefreshToken, generateRandomToken } from './tokens';
1616
import { emailTemplates, EmailTemplateType, sendMail } from './email';
1717
import {
1818
AccountsServerOptions,
@@ -186,13 +186,12 @@ export class AccountsServer {
186186
const { ip, userAgent } = infos;
187187

188188
try {
189-
// TODO get a random token
190-
const token = '';
189+
const token = generateRandomToken();
191190
const sessionId = await this.db.createSession(user.id, token, {
192191
ip,
193192
userAgent,
194193
});
195-
const { accessToken, refreshToken } = this.createTokens(sessionId);
194+
const { accessToken, refreshToken } = this.createTokens(token);
196195

197196
const loginResult = {
198197
sessionId,
@@ -266,8 +265,7 @@ export class AccountsServer {
266265
return { authorized: false };
267266
}
268267

269-
// TODO get a random token
270-
const token = '';
268+
const token = generateRandomToken();
271269
const newSessionId = await this.db.createSession(
272270
impersonatedUser.id,
273271
token,

packages/server/src/tokens.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
import * as jwt from 'jsonwebtoken';
22
import { randomBytes } from 'crypto';
33

4-
export const generateRandomToken = (length: number = 43) =>
4+
/**
5+
* Generate a random token string
6+
*/
7+
export const generateRandomToken = (length: number = 43): string =>
58
randomBytes(length).toString('hex');
69

710
export const generateAccessToken = ({

0 commit comments

Comments
 (0)