Skip to content

Commit fee5e30

Browse files
author
Nils Kreiner
committed
fixed validation
1 parent 59a221e commit fee5e30

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

backend/webserver/serializer/project_serializer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class Meta:
1212
fields = ["projectId", "projectName", "updated", "deploymentThreshold"]
1313

1414
projectId = serializers.CharField(source="project_id", read_only=True)
15-
projectName = serializers.CharField(source="project_name", allow_blank=True, max_length=255)
15+
projectName = serializers.CharField(source="project_name", allow_blank=True)
1616
updated = serializers.DateTimeField(default=datetime.now(), read_only=True)
1717
deploymentThreshold = serializers.ChoiceField(source="deployment_threshold", choices=Threshold.names)
1818

backend/webserver/views/project_views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ def post(self, request, project_id):
158158
else:
159159
raise InvalidValueError(project_id)
160160

161-
if len(request.data.get("projectName", "")) > 255:
162-
raise InvalidValueError("Project name exceeds the maximum length of 255 characters")
161+
if len(request.data.get("projectName", "")) > 50:
162+
raise InvalidValueError("Project name exceeds the maximum length of 50 characters")
163163

164164
return Response(f"Creation of {project_id} successful!")
165165

frontend/src/components/NavBar/ProjectCreationContent.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ const CreationContent: React.FunctionComponent<DialogContentProps> = (dialogCont
6464
}else if (projectId.includes(" ")){
6565
setIdInvalid(true);
6666
setProjectIdHelperText(localization.dialog.projectIdHelperNoSpaces)
67-
}else if (projectId.length > 20){
67+
}else if (projectId.length > 50){
6868
setIdInvalid(true);
6969
setProjectIdHelperText(localization.dialog.projectIdHelperToLong)
7070
}else {
@@ -81,7 +81,7 @@ const CreationContent: React.FunctionComponent<DialogContentProps> = (dialogCont
8181
}, [projectId, isProjectIdTouched, allProjectIds])
8282

8383
useEffect(() => {
84-
if (projectName.length > 25) {
84+
if (projectName.length > 50) {
8585
setNameInvalid(true);
8686
setProjectNameHelperText(localization.dialog.projectNameHelperToLong);
8787
} else {

frontend/src/queries/project-requests.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ export function createProject(projectId: string, projectData: {
3030
projectName: string,
3131
deploymentThreshold: string
3232
}): AxiosPromise {
33-
if (projectData.projectName && projectData.projectName.length > 25) {
34-
return Promise.reject(new Error("Project name exceeds the maximum length of 25 characters"));
33+
if (projectData.projectName && projectData.projectName.length > 50) {
34+
return Promise.reject(new Error("Project name exceeds the maximum length of 50 characters"));
3535
}
3636
return apiClient.post(urlAddress.api.createProject(projectId), projectData)
3737
}

frontend/src/utilities/localization.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ const language = {
283283
projectId: "Projekt ID",
284284
projectIdHelperNotEmpty: "Projekt ID darf nicht leer sein.",
285285
projectIdHelperNoSpaces: "Projekt ID darf keine Leerzeichen beinhalten.",
286-
projectIdHelperToLong: "Projekt ID ist länger als 20 Zeichen lang.",
286+
projectIdHelperToLong: "Projekt ID ist länger als 50 Zeichen lang.",
287287
projectIdHelperIdAlreadyUsed: "Projekt ID bereits vergeben.",
288288
projectName: "Projektname",
289289
projectNameHelperToLong: "Projektname zu lang.",
@@ -596,7 +596,7 @@ const language = {
596596
projectId: "Project ID",
597597
projectIdHelperNotEmpty: "Project ID mustn't be empty.",
598598
projectIdHelperNoSpaces: "Project ID mustn't contain spaces.",
599-
projectIdHelperToLong: "Project ID is longer than 20 characters.",
599+
projectIdHelperToLong: "Project ID is longer than 50 characters.",
600600
projectIdHelperIdAlreadyUsed: "Project ID already in use.",
601601
projectName: "Project name",
602602
projectNameHelperToLong: "Project name to long.",

0 commit comments

Comments
 (0)