Skip to content

Commit 56bd8be

Browse files
author
Dave MacFarlane
committed
Fix comments in tests
1 parent 4113081 commit 56bd8be

File tree

2 files changed

+8
-39
lines changed

2 files changed

+8
-39
lines changed

test/unittests/security/HOTP_Test.php

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,5 @@
11
<?php declare(strict_types=1);
22

3-
/**
4-
* This file contains unit test for the CandID value object.
5-
*
6-
* PHP Version 7
7-
*
8-
* @category Tests
9-
* @package StudyEntities
10-
* @author Xavier Lecours <[email protected]>
11-
* @license http://www.gnu.org/licenses/gpl-3.0.txt GPLv3
12-
* @link https://www.github.com/aces/Loris/
13-
*/
143
namespace LORIS\Security;
154

165
require_once __DIR__ . '/../../../vendor/autoload.php';
@@ -19,15 +8,10 @@
198
use \LORIS\Security\OTP\HOTP;
209

2110
/**
22-
* Unit test class for the CandID value object
23-
*
24-
* PHP Version 7
11+
* Group of tests for HMAC-based One Time Passwords (HOTP)
12+
* primarily based on RFC4226 test vectors.
2513
*
26-
* @category Tests
27-
* @package StudyEntities
28-
* @author Xavier Lecours <[email protected]>
29-
* @license http://www.gnu.org/licenses/gpl-3.0.txt GPLv3
30-
* @link https://www.github.com/aces/Loris/
14+
* @license http://www.gnu.org/licenses/gpl-3.0.txt GPLv3
3115
*/
3216
class HOTP_Test extends TestCase
3317
{

test/unittests/security/TOTP_Test.php

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,5 @@
11
<?php declare(strict_types=1);
22

3-
/**
4-
* This file contains unit test for the CandID value object.
5-
*
6-
* PHP Version 7
7-
*
8-
* @category Tests
9-
* @package StudyEntities
10-
* @author Xavier Lecours <[email protected]>
11-
* @license http://www.gnu.org/licenses/gpl-3.0.txt GPLv3
12-
* @link https://www.github.com/aces/Loris/
13-
*/
143
namespace LORIS\Security;
154

165
require_once __DIR__ . '/../../../vendor/autoload.php';
@@ -19,15 +8,10 @@
198
use \LORIS\Security\OTP\TOTP;
209

2110
/**
22-
* Unit test class for the CandID value object
23-
*
24-
* PHP Version 7
11+
* Unit test class for Time-based One Time Passwords (TOTP)
12+
* primarily based on RFC6238
2513
*
26-
* @category Tests
27-
* @package StudyEntities
28-
* @author Xavier Lecours <[email protected]>
29-
* @license http://www.gnu.org/licenses/gpl-3.0.txt GPLv3
30-
* @link https://www.github.com/aces/Loris/
14+
* @license http://www.gnu.org/licenses/gpl-3.0.txt GPLv3
3115
*/
3216
class TOTP_Test extends TestCase
3317
{
@@ -40,7 +24,8 @@ class TOTP_Test extends TestCase
4024
function testRFC6238Counters() : void
4125
{
4226
$totp = new TOTP("abc", timestep: 30);
43-
// Unix time => RFC6238 time based counter for HOTP
27+
// Unix time => RFC6238 time based counter to pass to HOTP
28+
// algorithm.
4429
$validValues = [
4530
59 => hexdec("0000000000000001"),
4631
1111111109 => hexdec("00000000023523EC"),

0 commit comments

Comments
 (0)