lint

Author: Saket Hatwar

modules/mri_violations/php/resolve.class.inc

@@ -1,8 +1,9 @@
 <?php declare(strict_types=1);
 
 namespace LORIS\mri_violations;
-use \Psr\Http\Message\ServerRequestInterface;
-use \Psr\Http\Message\ResponseInterface;
+
+use Psr\Http\Message\ServerRequestInterface;
+use Psr\Http\Message\ResponseInterface;
 
 /**
  * Implement and endpoint to handle POST requests which resolve
@@ -19,7 +20,7 @@ class Resolve extends \NDB_Page
      *
      * @return boolean true if the user is permitted to see violated scans
      */
-    function _hasAccess(\User $user) : bool
+    function _hasAccess(\User $user): bool
     {
         return $user->hasAnyPermission(
             [
@@ -37,18 +38,26 @@ class Resolve extends \NDB_Page
      *
      * @return ResponseInterface
      */
-    public function handle(ServerRequestInterface $request) : ResponseInterface
+    public function handle(ServerRequestInterface $request): ResponseInterface
     {
         $user = $request->getAttribute("user");
         if (!$this->_hasAccess($user)) {
-            return new \LORIS\Http\Response\JSON\Forbidden(dgettext('loris',
-             "Access denied"));
+            return new \LORIS\Http\Response\JSON\Forbidden(
+                dgettext(
+                    'loris',
+                    "Access denied"
+                )
+            );
         }
 
         $requestdata = json_decode((string) $request->getBody(), true);
         if (!is_array($requestdata)) {
-            return new \LORIS\Http\Response\JSON\BadRequest(dgettext('loris',
-             "Must submit data in JSON format"));
+            return new \LORIS\Http\Response\JSON\BadRequest(
+                dgettext(
+                    'loris',
+                    "Must submit data in JSON format"
+                )
+            );
         }
 
         $DB   = $this->loris->getDatabaseConnection();
@@ -80,7 +89,7 @@ class Resolve extends \NDB_Page
                 // Not modified
                 $response = $response->withStatus(304);
             }
-        } else if ($val !== 'unresolved') {
+        } elseif ($val !== 'unresolved') {
             // no need to insert to DB for Unresolved value.
 
             // Base of the insert
@@ -154,4 +163,3 @@ class Resolve extends \NDB_Page
         return $response;
     }
 }
-

modules/mri_violations/php/usercentermatchornull.class.inc

@@ -20,7 +20,7 @@ class UserCenterMatchOrNull implements \LORIS\Data\Filter
      *
      * @return bool
      */
-    public function filter(\User $user, \Loris\Data\DataInstance $resource) : bool
+    public function filter(\User $user, \Loris\Data\DataInstance $resource): bool
     {
         // phan only understands method_exists on simple variables.
         // Assigning to a variable is the a workaround
@@ -37,8 +37,10 @@ class UserCenterMatchOrNull implements \LORIS\Data\Filter
             return true;
         }
         throw new \LorisException(
-            dgettext('mri_violations', 
-            "Can not implement filter on a resource type that has no centers.")
+            dgettext(
+                'mri_violations',
+                "Can not implement filter on a resource type that has no centers."
+            )
         );
     }
 }

modules/mri_violations/php/usercentermatchornulloranypermission.class.inc

@@ -30,7 +30,7 @@ class UserCenterMatchOrNullOrAnyPermission implements \LORIS\Data\Filter
      *
      * @return bool
      */
-    public function filter(\User $user, \Loris\Data\DataInstance $resource) : bool
+    public function filter(\User $user, \Loris\Data\DataInstance $resource): bool
     {
         // phan only understands method_exists on simple variables.
         // Assigning to a variable is the a workaround
@@ -51,8 +51,10 @@ class UserCenterMatchOrNullOrAnyPermission implements \LORIS\Data\Filter
             return true;
         }
         throw new \LorisException(
-            dgettext('loris', 
-            "Can not implement filter on a resource type that has no centers.")
+            dgettext(
+                'loris',
+                "Can not implement filter on a resource type that has no centers."
+            )
         );
     }
 }

modules/mri_violations/php/userprojectmatchornull.class.inc

@@ -12,6 +12,7 @@
  * @license    http://www.gnu.org/licenses/gpl-3.0.txt GPLv3
  * @link       https://www.github.com/aces/Loris/
  */
+
 namespace LORIS\mri_violations;
 
 /**
@@ -40,7 +41,7 @@ class UserProjectMatchOrNull implements \LORIS\Data\Filter
      *
      * @return bool true if the user has a project in common with the data
      */
-    public function filter(\User $user, \Loris\Data\DataInstance $resource) : bool
+    public function filter(\User $user, \Loris\Data\DataInstance $resource): bool
     {
         // phan only understands method_exists on simple variables.
         // Assigning to a variable is the a workaround
@@ -57,8 +58,10 @@ class UserProjectMatchOrNull implements \LORIS\Data\Filter
             return true;
         }
         throw new \LorisException(
-            dgettext('loris', 
-            "Can not implement filter on a resource type that has no projects.")
+            dgettext(
+                'loris',
+                "Can not implement filter on a resource type that has no projects."
+            )
         );
     }
 }