Skip to content

Commit ecf82ea

Browse files
authored
Refactoring number validation logic and corrected maximum value error message (#1597)
Signed-off-by: rafsanneloy <rafsanneloy@gmail.com>
1 parent c027114 commit ecf82ea

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

BrainPortal/app/models/boutiques_portal_task.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ def sanitize_param(input)
568568
when :number
569569
if value.blank?
570570
params_errors.add(invokename, ": value missing")
571-
elsif (number = Integer(value) rescue Float(value) rescue nil)
571+
elsif (number = (Integer(value) rescue Float(value) rescue nil))
572572
value = number
573573
else
574574
params_errors.add(invokename, ": not a number (#{value})")
@@ -664,7 +664,7 @@ def check_number_param(input)
664664
ok = values.all? { |v| v < input.maximum.to_f } if clusive == 'exclusive'
665665
ok = values.all? { |v| v <= input.maximum.to_f } if clusive == 'inclusive'
666666
if ! ok
667-
params_errors.add(input.cb_invoke_name, "violates #{clusive} maximum value #{input.minimum}")
667+
params_errors.add(input.cb_invoke_name, "violates #{clusive} maximum value #{input.maximum}")
668668
end
669669
end
670670

0 commit comments

Comments
 (0)