Skip to content

Commit f572e7b

Browse files
mikebeatonMikhail Krichanov
authored andcommitted
.github/workflows: Change to non-recursive submodule checkout
Upstream, and our copy of the same file, recommend against recursive submodule checkout: https://github.com/mikebeaton/audk/blob/720bc76371ed5b57ce60226fb162d29c2e0b2c94/ReadMe.rst?plain=1#L274-L279 This is in order to avoid introducing unused dependencies, i.e. no EDK2 build steps refer to any code in sub-submodules. It is not believed that any code we have added needs recursive submodule checkout either, so changing this: a) Removes unused dependencies b) Speeds up builds c) Makes builds less prone to network timeouts Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>
1 parent 51db23c commit f572e7b

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

.github/workflows/build_arm.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
steps:
2222
- uses: actions/checkout@v4
2323
with:
24-
submodules: recursive
24+
submodules: true
2525

2626
- name: Install Dependencies
2727
run: |
@@ -115,7 +115,7 @@ jobs:
115115
steps:
116116
- uses: actions/checkout@v4
117117
with:
118-
submodules: recursive
118+
submodules: true
119119

120120
- name: Install Dependencies
121121
run: |

.github/workflows/build_common.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
steps:
2222
- uses: actions/checkout@v4
2323
with:
24-
submodules: recursive
24+
submodules: true
2525

2626
- name: Add Linux Toolchain
2727
run: brew tap FiloSottile/homebrew-musl-cross
@@ -155,7 +155,7 @@ jobs:
155155
steps:
156156
- uses: actions/checkout@v4
157157
with:
158-
submodules: recursive
158+
submodules: true
159159

160160
- name: Install Dependencies
161161
run: |
@@ -273,7 +273,7 @@ jobs:
273273
steps:
274274
- uses: actions/checkout@v4
275275
with:
276-
submodules: recursive
276+
submodules: true
277277

278278
- name: Use Docker in rootless mode.
279279
uses: ScribeMD/rootless-docker@0.2.2
@@ -409,7 +409,7 @@ jobs:
409409
steps:
410410
- uses: actions/checkout@v4
411411
with:
412-
submodules: recursive
412+
submodules: true
413413

414414
- name: Use Docker in rootless mode.
415415
uses: ScribeMD/rootless-docker@0.2.2
@@ -545,7 +545,7 @@ jobs:
545545
steps:
546546
- uses: actions/checkout@v4
547547
with:
548-
submodules: recursive
548+
submodules: true
549549

550550
- name: Use Docker in rootless mode.
551551
uses: ScribeMD/rootless-docker@0.2.2

.github/workflows/build_nolto.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
steps:
2222
- uses: actions/checkout@v4
2323
with:
24-
submodules: recursive
24+
submodules: true
2525

2626
- name: Install Dependencies
2727
run: |
@@ -118,7 +118,7 @@ jobs:
118118
steps:
119119
- uses: actions/checkout@v4
120120
with:
121-
submodules: recursive
121+
submodules: true
122122

123123
- name: Use Docker in rootless mode.
124124
uses: ScribeMD/rootless-docker@0.2.2
@@ -214,7 +214,7 @@ jobs:
214214
steps:
215215
- uses: actions/checkout@v4
216216
with:
217-
submodules: recursive
217+
submodules: true
218218

219219
- name: Use Docker in rootless mode.
220220
uses: ScribeMD/rootless-docker@0.2.2

.github/workflows/build_x86.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
steps:
2424
- uses: actions/checkout@v4
2525
with:
26-
submodules: recursive
26+
submodules: true
2727

2828
- name: Add Linux Toolchain
2929
run: brew tap FiloSottile/homebrew-musl-cross
@@ -133,7 +133,7 @@ jobs:
133133
steps:
134134
- uses: actions/checkout@v4
135135
with:
136-
submodules: recursive
136+
submodules: true
137137

138138
- name: Install Dependencies
139139
run: |
@@ -227,7 +227,7 @@ jobs:
227227
steps:
228228
- uses: actions/checkout@v4
229229
with:
230-
submodules: recursive
230+
submodules: true
231231

232232
- name: Use Docker in rootless mode.
233233
uses: ScribeMD/rootless-docker@0.2.2
@@ -319,7 +319,7 @@ jobs:
319319
steps:
320320
- uses: actions/checkout@v4
321321
with:
322-
submodules: recursive
322+
submodules: true
323323

324324
- name: Use Docker in rootless mode.
325325
uses: ScribeMD/rootless-docker@0.2.2
@@ -411,7 +411,7 @@ jobs:
411411
steps:
412412
- uses: actions/checkout@v4
413413
with:
414-
submodules: recursive
414+
submodules: true
415415

416416
- name: Use Docker in rootless mode.
417417
uses: ScribeMD/rootless-docker@0.2.2

0 commit comments

Comments
 (0)