feat: use npm for managing js packages (#571)

We've decided that we want to use `npm` as our package manager for
JavaScript dependencies, so this removes our explicit support for the
other package managers, though we still remain pretty agnostic due to
the use of `PackageJson` which I've retained for now given it's
lightweight and secretly I'm keen to explore `pnpm` at some point so
this will come in handy if that turns out to be worth switching to 😄

I've also retained the "create fake package managers" script + ci step
to ensure that we really are only ever using `npm`; I plan to explore
refactoring that script given we no longer need to support all the
package managers as a follow-up since it too is lightweight and
perfectly functional as-is.

Author: G-Rath

.github/workflows/ci.yml

@@ -49,9 +49,9 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version-file: '.node-version'
-          cache: 'yarn'
-      - run: yarn install
-      - run: yarn run format-check
+          cache: 'npm'
+      - run: npm ci
+      - run: npm run format-check
 
   rubocop:
     permissions:
@@ -79,24 +79,6 @@ jobs:
       # how many fail)
       fail-fast: false
       matrix:
-        js_package_manager:
-          - name: npm
-            installer: npm
-          - name: yarn_berry
-            installer: yarn
-            linker: pnp
-          - name: yarn_berry
-            installer: yarn
-            linker: node-modules
-          - name: yarn_berry
-            installer: yarn
-            linker: pnpm
-          - name: yarn_classic
-            installer: yarn
-          - name: pnpm
-            installer: pnpm
-          - name: bun
-            installer: bun
         variant:
           - name: defaults
             config_path: 'ackama_rails_template.config.yml'
@@ -173,8 +155,8 @@ jobs:
         with:
           node-version-file: '.node-version'
 
-      - name: install package manager
-        run: npm i -g ${{ matrix.js_package_manager.installer }}
+      - name: Install latest version of npm
+        run: npm i -g npm
 
       # We don't cache gems or JS packages because we are actually testing how
       # installation and setup works in this project so, while caching would
@@ -192,8 +174,7 @@ jobs:
           git config --global user.email "[email protected]"
           git config --global user.name "Your Name"
 
-      # prettier-ignore
-      - run: ./ci/bin/create-fake-js-package-managers ${{ matrix.js_package_manager.installer }}
+      - run: ./ci/bin/create-fake-js-package-managers npm
 
       - name: Run CI script
         env:
@@ -207,7 +188,4 @@ jobs:
           PGUSER: postgres
           PGPASSWORD: postgres
           PGHOST: localhost
-          PACKAGE_JSON_FALLBACK_MANAGER: ${{ matrix.js_package_manager.name }}
-          PACKAGE_JSON_YARN_BERRY_LINKER:
-            ${{ matrix.js_package_manager.linker }}
         run: ./ci/bin/build-and-test

README.md

@@ -33,7 +33,7 @@ Where possible we stick to Rails defaults.
 
 - General
   - [puma](https://github.com/puma/puma) as application server
-  - [Yarn](https://yarnpkg.com/) for managing JS packages
+  - [npm](https://www.npmjs.com/) for managing JS packages
   - PostgreSQL as database. This template only supports PostgreSQL.
   - A much-improved `bin/setup` script
   - Install [dotenv](https://github.com/bkeepers/dotenv)
@@ -155,7 +155,7 @@ our other templates:
 Before running this template, you must have the following installed on your
 machine:
 
-- Yarn v1.21.0 or later
+- NPM v10.0.0 or later
 - Rails 7.1.x
 
 The following are not strictly required to run the template but you will need it

package-lock.json

@@ -177,8 +177,6 @@ def apply_template! # rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Met
       package_json.manager.run!("typecheck")
     end
 
-    ensure_yarn_files_are_not_linted
-
     # apply any js linting fixes after all frontend variants have run
     package_json.manager.run!("js-lint-fix")
 
@@ -266,78 +264,7 @@ def apply_prettier_all_over
   git commit: ". -m 'Run prettier one last time'"
 end
 
-# Sets Yarn Berry up in the project directory by initializing it with what is probably Yarn Classic.
-#
-# This is required as the Berry binary is actually downloaded and committed to the codebase, and
-# the global yarn command passes through to it when detected (even if its Yarn Classic).
-#
-# This also requires us to temporarily create a package.json as otherwise Yarn Berry will
-# look up the file tree and initialize itself in every directory that has a yarn.lock
-def setup_yarn_berry
-  # safeguard against parent directories having a yarn.lock
-  File.write("package.json", "{}") unless File.exist?("package.json")
-
-  run "yarn init -2"
-  run "yarn config set enableGlobalCache true"
-  run "yarn config set nodeLinker #{ENV.fetch("PACKAGE_JSON_YARN_BERRY_LINKER", "node-modules")}"
-
-  ignores = <<~YARN
-    .pnp.*
-    .yarn/*
-    !.yarn/patches
-    !.yarn/plugins
-    !.yarn/releases
-    !.yarn/sdks
-    !.yarn/versions
-  YARN
-  File.write(".gitignore", ignores, mode: "a")
-
-  # this will be properly (re)created later
-  File.unlink("package.json")
-end
-
-# Bun uses a binary-based lockfile which cannot be parsed by shakapacker or
-# osv-detector, so we want to configure bun to always write a yarn.lock
-# in addition so that such tools can check it
-def setup_bun
-  File.write("bunfig.toml", <<~TOML)
-    [install.lockfile]
-    print = "yarn"
-  TOML
-end
-
-def add_yarn_package_extension_dependency(name, dependency)
-  return unless File.exist?(".yarnrc.yml")
-
-  require "yaml"
-
-  yarnrc = YAML.load_file(".yarnrc.yml")
-
-  yarnrc["packageExtensions"] ||= {}
-  yarnrc["packageExtensions"]["#{name}@*"] ||= {}
-  yarnrc["packageExtensions"]["#{name}@*"]["dependencies"] ||= {}
-  yarnrc["packageExtensions"]["#{name}@*"]["dependencies"][dependency] = "*"
-
-  File.write(".yarnrc.yml", yarnrc.to_yaml)
-end
-
-# Ensures that files related to Yarn Berry are ignored by ESLint
-def ensure_yarn_files_are_not_linted
-  return unless Dir.exist?(".yarn") && File.exist?("eslint.config.js")
-
-  gsub_file!(
-    "eslint.config.js",
-    "  { ignores: ['tmp/*'] },",
-    "  { ignores: ['tmp/*', '.yarn/*', '.pnp.cjs', '.pnp.loader.mjs'] },"
-  )
-end
-
 def package_json
-  if @package_json.nil?
-    setup_yarn_berry if ENV.fetch("PACKAGE_JSON_FALLBACK_MANAGER", nil) == "yarn_berry"
-    setup_bun if ENV.fetch("PACKAGE_JSON_FALLBACK_MANAGER", nil) == "bun"
-  end
-
   @package_json ||= PackageJson.new
 end
 
@@ -359,8 +286,7 @@ def build_engines_field(existing)
   node_version = File.read("./.node-version").strip
 
   existing.merge({
-    "node" => "^#{node_version}",
-    "yarn" => "^1.0.0"
+    "node" => "^#{node_version}"
   })
 end
 
@@ -374,9 +300,6 @@ def cleanup_package_json
     }
   end
 
-  # TODO: this doesn't work when using pnpm even though it shouldn't matter? anyway, replace with 'exec' support
-  # run "npx -y sort-package-json"
-
   # ensure the lockfile is up to date with any changes we've made to package.json
   package_json.manager.install!
 end

template.rb

@@ -12,11 +12,3 @@
     Lighthouse::Matchers.chrome_flags = %w[headless=new no-sandbox]
   OPTIONS
 end
-
-if File.exist?(".yarnrc.yml")
-  insert_into_file! "spec/rails_helper.rb", after: /# Lighthouse Matcher options\n/ do
-    <<~OPTIONS
-      Lighthouse::Matchers.lighthouse_cli = "yarn run lighthouse"
-    OPTIONS
-  end
-end

variants/accessibility/spec/rails_helper.rb

@@ -39,9 +39,6 @@ RUN apt-get update -qq &&\
            /usr/share/locales \
            /var/cache/apt/archives
 
-# Use NPM to install Yarn.
-RUN npm install -g yarn
-
 # Install gem and NPM dependencies. These are baked into the image so the image can run
 # standalone provided valid configuration. When running in docker-compose, these
 # dependencies are stored in a volume so the image does not need rebuilding when the
@@ -56,10 +53,10 @@ USER deploy
 
 # Add just the dependency manifests before installing.
 # This reduces the chance that bundler or NPM will get a cold cache because some kind of application file changed.
-ADD Gemfile* package.json yarn.lock /usr/src/app/
+ADD Gemfile* package.json package-lock.json /usr/src/app/
 WORKDIR /usr/src/app
 RUN bundle check || bundle install &&\
-    yarn install --frozen-lockfile
+    npm ci
 
 # Add all application code to /usr/src/app and set this as the working directory
 # of the container

variants/backend-base/Dockerfile

@@ -1,8 +1,6 @@
 # Javascript code linting and formatting
 # ######################################
 
-add_yarn_package_extension_dependency("eslint-plugin-prettier", "eslint-config-prettier")
-
 add_js_dependencies %w[
   @eslint-community/eslint-plugin-eslint-comments
   @stylistic/eslint-plugin-js@3

variants/frontend-base/js-lint/template.rb

@@ -7,8 +7,6 @@
 
 run "rails generate react:install"
 
-add_yarn_package_extension_dependency("@testing-library/user-event", "@testing-library/dom")
-
 # prefer importing from the more specific package for consistency
 gsub_file! "app/frontend/test/stimulus/controllers/add_class_controller.test.js",
            "'@testing-library/dom'",

variants/frontend-react/template.rb

@@ -1,13 +1,5 @@
 source_paths.unshift(File.dirname(__FILE__))
 
-add_yarn_package_extension_dependency("@testing-library/jest-dom", "@types/aria-query")
-add_yarn_package_extension_dependency("ts-jest", "@jest/transform")
-add_yarn_package_extension_dependency("ts-jest", "@jest/types")
-add_yarn_package_extension_dependency("ts-jest", "jest-util")
-add_yarn_package_extension_dependency("@jest/test-result", "jest-haste-map")
-add_yarn_package_extension_dependency("@jest/test-result", "jest-resolve")
-add_yarn_package_extension_dependency("jest-cli", "@types/yargs")
-
 add_js_dependencies ["@babel/plugin-transform-typescript"]
 add_js_dependencies [
   "@types/jest@#{JEST_MAJOR_VERSION}",

variants/frontend-stimulus-typescript/template.rb

@@ -49,7 +49,7 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version-file: '.node-version'
-          cache: 'yarn'
+          cache: 'npm'
       - run: <%= package_json.manager.native_install_command(frozen: true).join(" ") %>
       <%- if TEMPLATE_CONFIG.use_typescript? -%>
       - run: <%= package_json.manager.native_run_command("typecheck").join(" ") %>
@@ -109,7 +109,7 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version-file: '.node-version'
-          cache: 'yarn'
+          cache: 'npm'
       - run: <%= package_json.manager.native_install_command(frozen: true).join(" ") %>
       - run: bundle exec rspec spec --format progress
       - name: Archive spec outputs