From 16d0727c769edbf2c42fb9fbdbf6bf79edc25aa9 Mon Sep 17 00:00:00 2001
From: Matt Post <mattpost@microsoft.com>
Date: Fri, 1 Sep 2023 16:12:45 -0400
Subject: [PATCH] Removed comments, added option attribute to volume-id

---
 bin/anthology/utils.py | 3 ---
 data/xml/2023.ws.xml   | 9 +++------
 data/xml/schema.rnc    | 2 +-
 3 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/bin/anthology/utils.py b/bin/anthology/utils.py
index c285d50d00..572e871f93 100644
--- a/bin/anthology/utils.py
+++ b/bin/anthology/utils.py
@@ -433,9 +433,6 @@ def parse_element(
         return attrib
 
     for element in xml_element:
-        if element.tag is etree.Comment:
-            continue
-
         # parse value
         tag = element.tag.lower()
         if tag in dont_parse_elements:
diff --git a/data/xml/2023.ws.xml b/data/xml/2023.ws.xml
index fe822d593d..6f9b2493e6 100644
--- a/data/xml/2023.ws.xml
+++ b/data/xml/2023.ws.xml
@@ -2,8 +2,7 @@
 <collection id="2023.ws">
   <event id="ws-2023">
     <colocated>
-      <!-- Unsorted -->
-      <volume-id>2023.computel-1</volume-id>
+      <volume-id note="unsorted">2023.computel-1</volume-id>
       <volume-id>2023.wsc-csdh</volume-id>
       <volume-id>2023.depling-1</volume-id>
       <volume-id>2023.cxgsnlp-1</volume-id>
@@ -11,8 +10,7 @@
       <volume-id>2023.udw-1</volume-id>
       <volume-id>2023.resourceful-1</volume-id>
       <volume-id>2023.nlp4call-1</volume-id>
-      <!-- EACL 2023 -->
-      <volume-id>2023.bsnlp-1</volume-id>
+      <volume-id note="eacl">2023.bsnlp-1</volume-id>
       <volume-id>2023.c3nlp-1</volume-id>
       <volume-id>2023.fever-1</volume-id>
       <volume-id>2023.fieldmatters-1</volume-id>
@@ -24,8 +22,7 @@
       <volume-id>2023.sigtyp-1</volume-id>
       <volume-id>2023.unlp-1</volume-id>
       <volume-id>2023.vardial-1</volume-id>
-      <!-- ACL 2023 -->
-      <volume-id>2023.americasnlp-1</volume-id>
+      <volume-id note="acl">2023.americasnlp-1</volume-id>
       <volume-id>2023.bea-1</volume-id>
       <volume-id>2023.bionlp-1</volume-id>
       <volume-id>2023.cawl-1</volume-id>
diff --git a/data/xml/schema.rnc b/data/xml/schema.rnc
index dabcbd8bed..e4fd0bef61 100644
--- a/data/xml/schema.rnc
+++ b/data/xml/schema.rnc
@@ -144,7 +144,7 @@ Event = element event {
    & element links { url* }?
    & Talk*
    & element colocated {
-       element volume-id { text }*
+       element volume-id { attribute note { xsd:string }?, text }*
      }?
  )
 }