fix unit tests

Author: devksingh4

src/api/routes/membership.ts

@@ -174,7 +174,7 @@ const membershipPlugin: FastifyPluginAsync = async (fastify, _options) => {
         schema: withTags(["Membership"], {
           params: z
             .object({ netId: z.string().min(1) })
-            .refine((data) => !validateNetId(data.netId), {
+            .refine((data) => validateNetId(data.netId), {
               message: "NetID is not valid!",
               path: ["netId"],
             }),
@@ -191,11 +191,6 @@ const membershipPlugin: FastifyPluginAsync = async (fastify, _options) => {
       async (request, reply) => {
         const netId = request.params.netId.toLowerCase();
         const list = request.query.list || "acmpaid";
-        if (!validateNetId(netId)) {
-          throw new ValidationError({
-            message: `${netId} is not a valid Illinois NetID!`,
-          });
-        }
         if (fastify.nodeCache.get(`isMember_${netId}_${list}`) !== undefined) {
           return reply.header("X-ACM-Data-Source", "cache").send({
             netId,

tests/unit/stripe.test.ts

@@ -103,7 +103,7 @@ describe("Test Stripe link creation", async () => {
       name: "ValidationError",
       id: 104,
       message:
-        'String must contain at least 1 character(s) at "invoiceId"; Number must be greater than or equal to 50 at "invoiceAmountUsd"; String must contain at least 1 character(s) at "contactName"; Required at "contactEmail"',
+        "body/invoiceId String must contain at least 1 character(s), body/invoiceAmountUsd Number must be greater than or equal to 50, body/contactName String must contain at least 1 character(s), body/contactEmail Required",
     });
     expect(ddbMock.calls().length).toEqual(0);
     expect(smMock.calls().length).toEqual(0);
@@ -130,7 +130,7 @@ describe("Test Stripe link creation", async () => {
       error: true,
       name: "ValidationError",
       id: 104,
-      message: 'Invalid email at "contactEmail"',
+      message: "body/contactEmail Invalid email",
     });
     expect(ddbMock.calls().length).toEqual(0);
     expect(smMock.calls().length).toEqual(0);

tests/unit/tickets.test.ts

@@ -199,8 +199,7 @@ describe("Test ticket purchase verification", async () => {
     expect(responseDataJson).toEqual({
       error: true,
       id: 104,
-      message:
-        'Invalid literal value, expected "merch" at "type", or Required at "ticketId"',
+      message: "body/ Invalid input",
       name: "ValidationError",
     });
   });
@@ -354,7 +353,7 @@ describe("Test merch purchase verification", async () => {
     expect(responseDataJson).toEqual({
       error: true,
       id: 104,
-      message: `Required at "email"; Required at "stripePi", or Invalid literal value, expected "ticket" at "type"`,
+      message: `body/ Invalid input`,
       name: "ValidationError",
     });
   });

yarn.lock

@@ -4818,19 +4818,19 @@ axe-core@^4.10.0:
   resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.10.2.tgz#85228e3e1d8b8532a27659b332e39b7fa0e022df"
   integrity sha512-RE3mdQ7P3FRSe7eqCWoeQ/Z9QXrtniSjp1wUjt5nRC3WIpz5rSCve6o3fsZ2aCpJtrZjSZgjwXAoTO5k4tEI0w==
 
-axios@^1.7.3, axios@^1.7.7:
-  version "1.7.9"
-  resolved "https://registry.yarnpkg.com/axios/-/axios-1.7.9.tgz#d7d071380c132a24accda1b2cfc1535b79ec650a"
-  integrity sha512-LhLcE7Hbiryz8oMDdDptSrWowmB4Bl6RCt6sIJKpRB4XtVf0iEgewX3au/pJqm+Py1kCASkb/FFKjxQaLtxJvw==
+axios@^1.7.4, axios@^1.8.4:
+  version "1.8.4"
+  resolved "https://registry.yarnpkg.com/axios/-/axios-1.8.4.tgz#78990bb4bc63d2cae072952d374835950a82f447"
+  integrity sha512-eBSYY4Y68NNlHbHBMdeDmKNtDgXWhQsJcGqzO3iLUM0GraQFSS9cVgPX5I9b3lbdFKyYoAEGAZF1DwhTaljNAw==
   dependencies:
     follow-redirects "^1.15.6"
     form-data "^4.0.0"
     proxy-from-env "^1.1.0"
 
-axios@^1.7.4:
-  version "1.8.4"
-  resolved "https://registry.yarnpkg.com/axios/-/axios-1.8.4.tgz#78990bb4bc63d2cae072952d374835950a82f447"
-  integrity sha512-eBSYY4Y68NNlHbHBMdeDmKNtDgXWhQsJcGqzO3iLUM0GraQFSS9cVgPX5I9b3lbdFKyYoAEGAZF1DwhTaljNAw==
+axios@^1.7.7:
+  version "1.7.9"
+  resolved "https://registry.yarnpkg.com/axios/-/axios-1.7.9.tgz#d7d071380c132a24accda1b2cfc1535b79ec650a"
+  integrity sha512-LhLcE7Hbiryz8oMDdDptSrWowmB4Bl6RCt6sIJKpRB4XtVf0iEgewX3au/pJqm+Py1kCASkb/FFKjxQaLtxJvw==
   dependencies:
     follow-redirects "^1.15.6"
     form-data "^4.0.0"
@@ -6610,10 +6610,10 @@ fastify-zod-openapi@^4.1.1:
     fast-json-stringify "^6.0.0"
     fastify-plugin "^5.0.0"
 
-fastify@^5.1.0:
-  version "5.2.1"
-  resolved "https://registry.yarnpkg.com/fastify/-/fastify-5.2.1.tgz#38381800eb26b7e27da72d9ee51c544f0c52ff39"
-  integrity sha512-rslrNBF67eg8/Gyn7P2URV8/6pz8kSAscFL4EThZJ8JBMaXacVdVE4hmUcnPNKERl5o/xTiBSLfdowBRhVF1WA==
+fastify@^5.3.2:
+  version "5.3.2"
+  resolved "https://registry.yarnpkg.com/fastify/-/fastify-5.3.2.tgz#88c895a30c0f67166979077ac8649fe8b205a1b3"
+  integrity sha512-AIPqBgtqBAwkOkrnwesEE+dOyU30dQ4kh7udxeGVR05CRGwubZx+p2H8P0C4cRnQT0+EPK4VGea2DTL2RtWttg==
   dependencies:
     "@fastify/ajv-compiler" "^4.0.0"
     "@fastify/error" "^4.0.0"
@@ -6625,9 +6625,9 @@ fastify@^5.1.0:
     find-my-way "^9.0.0"
     light-my-request "^6.0.0"
     pino "^9.0.0"
-    process-warning "^4.0.0"
+    process-warning "^5.0.0"
     rfdc "^1.3.1"
-    secure-json-parse "^3.0.1"
+    secure-json-parse "^4.0.0"
     semver "^7.6.0"
     toad-cache "^3.7.0"
 
@@ -9063,6 +9063,11 @@ process-warning@^4.0.0:
   resolved "https://registry.yarnpkg.com/process-warning/-/process-warning-4.0.1.tgz#5c1db66007c67c756e4e09eb170cdece15da32fb"
   integrity sha512-3c2LzQ3rY9d0hc1emcsHhfT9Jwz0cChib/QN89oME2R451w5fy3f0afAhERFZAwrbDU43wk12d0ORBpDVME50Q==
 
+process-warning@^5.0.0:
+  version "5.0.0"
+  resolved "https://registry.yarnpkg.com/process-warning/-/process-warning-5.0.0.tgz#566e0bf79d1dff30a72d8bbbe9e8ecefe8d378d7"
+  integrity sha512-a39t9ApHNx2L4+HBnQKqxxHNs1r7KF+Intd8Q/g1bUh6q0WIp9voPXJ/x0j+ZL45KF1pJd9+q2jLIRMfvEshkA==
+
 process@^0.11.10:
   version "0.11.10"
   resolved "https://registry.yarnpkg.com/process/-/process-0.11.10.tgz#7332300e840161bda3e69a1d1d91a7d4bc16f182"
@@ -9703,10 +9708,10 @@ secure-json-parse@^2.4.0:
   resolved "https://registry.yarnpkg.com/secure-json-parse/-/secure-json-parse-2.7.0.tgz#5a5f9cd6ae47df23dba3151edd06855d47e09862"
   integrity sha512-6aU+Rwsezw7VR8/nyvKTx8QpWH9FrcYiXXlqC4z5d5XQBDRqtbfsRjnwGyqbi3gddNtWHuEk9OANUotL26qKUw==
 
-secure-json-parse@^3.0.1:
-  version "3.0.2"
-  resolved "https://registry.yarnpkg.com/secure-json-parse/-/secure-json-parse-3.0.2.tgz#255b03bb0627ba5805f64f384b0a7691d8cb021b"
-  integrity sha512-H6nS2o8bWfpFEV6U38sOSjS7bTbdgbCGU9wEM6W14P5H0QOsz94KCusifV44GpHDTu2nqZbuDNhTzu+mjDSw1w==
+secure-json-parse@^4.0.0:
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/secure-json-parse/-/secure-json-parse-4.0.0.tgz#2ee1b7581be38ab348bab5a3e49280ba80a89c85"
+  integrity sha512-dxtLJO6sc35jWidmLxo7ij+Eg48PM/kleBsxpC8QJE0qJICe+KawkDQmvCMZUr9u7WKVHgMW6vy3fQ7zMiFZMA==
 
 semver@^5.5.0:
   version "5.7.2"