fix unit tests

Author: devksingh4

src/api/components/index.ts

@@ -1,4 +1,3 @@
-import { FastifySchema } from "fastify";
 import { z } from "zod";
 
 export const ts = z.coerce

src/api/routes/ics.ts

@@ -63,7 +63,7 @@ const icalPlugin: FastifyPluginAsync = async (fastify, _options) => {
       } satisfies FastifyZodOpenApiSchema),
     },
     async (request, reply) => {
-      const host = request.params.host || "ACM";
+      const host = request.params.host;
       let queryParams: QueryCommandInput = {
         TableName: genericConfig.EventsDynamoTableName,
       };
@@ -151,7 +151,7 @@ const icalPlugin: FastifyPluginAsync = async (fastify, _options) => {
               rawEvent.description
             : `Host: ${rawEvent.host}\n\n` + rawEvent.description,
           timezone: "America/Chicago",
-          organizer: generateHostName(host),
+          organizer: generateHostName(host || "ACM"),
           id: rawEvent.id,
         });
 

tests/unit/eventPost.test.ts

@@ -76,7 +76,7 @@ test("Sad path: Prevent empty body request", async () => {
     error: true,
     name: "ValidationError",
     id: 104,
-    message: `Required at "title"; Required at "description"; Required at "start"; Required at "location"; Required at "host"`,
+    message: "body/ Expected object, received null",
   });
 });
 test("Sad path: Prevent specifying repeatEnds on non-repeating events", async () => {
@@ -106,7 +106,7 @@ test("Sad path: Prevent specifying repeatEnds on non-repeating events", async ()
     error: true,
     name: "ValidationError",
     id: 104,
-    message: "repeats is required when repeatEnds is defined",
+    message: "body/ repeats is required when repeatEnds is defined",
   });
 });
 
@@ -137,7 +137,8 @@ test("Sad path: Prevent specifying unknown repeat frequencies", async () => {
     error: true,
     name: "ValidationError",
     id: 104,
-    message: `Invalid enum value. Expected 'weekly' | 'biweekly', received 'forever_and_ever' at "repeats"`,
+    message:
+      "body/repeats Invalid enum value. Expected 'weekly' | 'biweekly', received 'forever_and_ever'",
   });
 });
 

tests/unit/ical.test.ts

@@ -33,9 +33,7 @@ test("Test getting ACM-wide iCal calendar", async () => {
 test("Test getting non-existent iCal calendar fails", async () => {
   const date = new Date(2024, 7, 22, 15, 51, 48); // August 22, 2024, at 15:51:48 (3:51:48 PM)
   vi.setSystemTime(date);
-  ddbMock.on(ScanCommand).resolves({
-    Items: dynamoTableData as any,
-  });
+  ddbMock.on(ScanCommand).rejects();
   const response = await app.inject({
     method: "GET",
     url: "/api/v1/ical/invalid",

tests/unit/vitest.setup.ts

@@ -1,3 +1,4 @@
+import "zod-openapi/extend";
 import { vi, afterEach } from "vitest";
 import { allAppRoles, AppRoles } from "../../src/common/roles.js";
 import { DynamoDBClient, QueryCommand } from "@aws-sdk/client-dynamodb";