Set event description to max length of 250 characters (#279)

Author: devksingh4

src/api/components/index.ts

@@ -1,7 +1,7 @@
 import { AppRoleHumanMapper, AppRoles } from "common/roles.js";
 import { FastifyZodOpenApiSchema } from "fastify-zod-openapi";
 import * as z from "zod/v4";
-import { CoreOrganizationList } from "@acm-uiuc/js-shared";
+import { AllOrganizationList } from "@acm-uiuc/js-shared";
 export {
   illinoisSemesterId as semesterId,
   illinoisNetId,
@@ -21,7 +21,7 @@ export const groupId = z.string().min(1).meta({
 });
 
 export const acmCoreOrganization = z
-  .enum(CoreOrganizationList as [string, ...string[]])
+  .enum(AllOrganizationList as [string, ...string[]])
   .meta({
     description: "ACM Organization",
     id: "AcmOrganization",

src/api/routes/events.ts

@@ -1,4 +1,4 @@
-import { FastifyPluginAsync, FastifyRequest } from "fastify";
+import { FastifyPluginAsync } from "fastify";
 import { AppRoles } from "../../common/roles.js";
 import * as z from "zod/v4";
 import {
@@ -141,7 +141,7 @@ const baseSchema = z.object({
   }),
   host: acmCoreOrganization,
   featured: z.boolean().default(false).meta({
-    ref: "acmOrganizationList",
+    ref: "featuredEventBool",
     description:
       "Whether or not the event should be shown on the ACM @ UIUC website home page (and added to Discord, as available).",
   }),
@@ -159,12 +159,16 @@ const requestSchema = baseSchema.extend({
 });
 
 const postRequestSchema = requestSchema
+  .extend({
+    description: z.string().min(1).max(250),
+  })
   .refine((data) => (data.repeatEnds ? data.repeats !== undefined : true), {
     message: "repeats is required when repeatEnds is defined",
   })
   .refine((data) => (data.repeatExcludes ? data.repeats !== undefined : true), {
     message: "repeats is required when repeatExcludes is defined",
   });
+
 export type EventPostRequest = z.infer<typeof postRequestSchema>;
 
 const getEventSchema = requestSchema.extend({

src/ui/pages/events/ManageEvent.page.tsx

@@ -84,6 +84,7 @@ const requestBodySchema = baseBodySchema
   .extend({
     start: z.coerce.date(),
     end: z.coerce.date(),
+    description: z.string().min(1).max(250),
     repeats: z.optional(z.enum(repeatOptions)).nullable(),
     repeatEnds: z.coerce.date().optional(),
     repeatExcludes: z.array(z.coerce.date()).max(100).optional(),
@@ -370,6 +371,7 @@ export const ManageEventPage: React.FC = () => {
             label="Event Description"
             withAsterisk
             placeholder="Event description"
+            description="Maximum 250 characters - be concise!"
             {...form.getInputProps("description")}
           />
 

tests/unit/eventPost.test.ts

@@ -106,6 +106,34 @@ test("Sad path: Prevent specifying repeatEnds on non-repeating events", async ()
   });
 });
 
+test("Sad path: Description is too long", async () => {
+  ddbMock.on(PutItemCommand).resolves({});
+  const testJwt = createJwt();
+  await app.ready();
+  const response = await supertest(app.server)
+    .post("/api/v1/events")
+    .set("authorization", `Bearer ${testJwt}`)
+    .send({
+      description: "a".repeat(260),
+      end: "2024-09-25T19:00:00",
+      featured: false,
+      host: "Social Committee",
+      location: "Illini Union",
+      start: "2024-09-25T18:00:00",
+      title: "Fall Semiformal",
+      repeats: "weekly",
+      paidEventId: "sp24_semiformal",
+    });
+
+  expect(response.statusCode).toBe(400);
+  expect(response.body).toStrictEqual({
+    error: true,
+    name: "ValidationError",
+    id: 104,
+    message: `body/description Too big: expected string to have <=250 characters`,
+  });
+});
+
 test("Sad path: Prevent specifying unknown repeat frequencies", async () => {
   ddbMock.on(PutItemCommand).resolves({});
   const testJwt = createJwt();