Update alarms

Author: devksingh4

terraform/envs/qa/variables.tf

@@ -35,10 +35,10 @@ variable "EmailDomain" {
 
 variable "GeneralSNSAlertArn" {
   type    = string
-  default = "arn:aws:sns:us-east-1:427040638965:infra-monitor-alerts:6556b66f-de43-49cd-9dee-5796b07b4ae8"
+  default = "arn:aws:sns:us-east-1:427040638965:infra-monitor-alerts"
 }
 
 variable "PrioritySNSAlertArn" {
   type    = string
-  default = "arn:aws:sns:us-east-1:427040638965:infra-monitor-alerts:6556b66f-de43-49cd-9dee-5796b07b4ae8"
+  default = "arn:aws:sns:us-east-1:427040638965:infra-monitor-alerts"
 }

terraform/modules/alarms/main.tf

@@ -11,7 +11,7 @@ resource "aws_cloudwatch_metric_alarm" "app_dlq_messages_alarm" {
   alarm_description   = "Items are present in the application DLQ, meaning some messages failed to process."
   namespace           = "AWS/SQS"
   metric_name         = "ApproximateNumberOfMessagesVisible"
-  statistic           = "Maximum"
+  statistic           = "Sum"
   period              = 60
   evaluation_periods  = 1
   comparison_operator = "GreaterThanThreshold"
@@ -22,19 +22,20 @@ resource "aws_cloudwatch_metric_alarm" "app_dlq_messages_alarm" {
   alarm_actions = [
     var.priority_sns_arn
   ]
+  treat_missing_data = "notBreaching"
 }
 
 resource "aws_cloudwatch_metric_alarm" "app_latency_alarm" {
   for_each            = var.performance_noreq_lambdas
   alarm_name          = "${each.value}-latency-high"
-  alarm_description   = "${replace(each.value, var.resource_prefix, "")} Trailing Mean - 95% API gateway latency is > 1.25s for 2 times in 4 minutes."
+  alarm_description   = "${replace(each.value, "${var.resource_prefix}-", "")} Trailing Mean - 95% API gateway latency is > 1.5s for 2 times in 4 minutes."
   namespace           = "AWS/Lambda"
   metric_name         = "UrlRequestLatency"
   extended_statistic  = "tm95"
   period              = "120"
   evaluation_periods  = "2"
   comparison_operator = "GreaterThanThreshold"
-  threshold           = "1250"
+  threshold           = "1500"
   alarm_actions = [
     var.standard_sns_arn
   ]
@@ -46,7 +47,7 @@ resource "aws_cloudwatch_metric_alarm" "app_latency_alarm" {
 resource "aws_cloudwatch_metric_alarm" "app_no_requests_alarm" {
   for_each            = var.performance_noreq_lambdas
   alarm_name          = "${each.value}-no-requests"
-  alarm_description   = "${replace(each.value, var.resource_prefix, "")}: no requests have been received in the past 5 minutes."
+  alarm_description   = "${replace(each.value, "${var.resource_prefix}-", "")}: no requests have been received in the past 5 minutes."
   namespace           = "AWS/Lambda"
   metric_name         = "UrlRequestCount"
   statistic           = "Sum"
@@ -65,7 +66,7 @@ resource "aws_cloudwatch_metric_alarm" "app_no_requests_alarm" {
 resource "aws_cloudwatch_metric_alarm" "app_invocation_error_alarm" {
   for_each            = var.all_lambdas
   alarm_name          = "${each.value}-error-invocation"
-  alarm_description   = "${replace(each.value, var.resource_prefix, "")} lambda threw a critical error."
+  alarm_description   = "${replace(each.value, "${var.resource_prefix}-", "")} lambda threw a critical error."
   namespace           = "AWS/Lambda"
   metric_name         = "Errors"
   statistic           = "Sum"