Skip to content

Commit a4fc884

Browse files
committed
consolidate stages to fix concurrency
1 parent 8aafb49 commit a4fc884

File tree

2 files changed

+7
-75
lines changed

2 files changed

+7
-75
lines changed

.github/workflows/deploy-dev.yml

Lines changed: 2 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
- name: Run unit testing
3939
run: make test_unit
4040

41-
deploy-dev:
41+
deploy-test-dev:
4242
runs-on: ubuntu-latest
4343
permissions:
4444
id-token: write
@@ -47,7 +47,7 @@ jobs:
4747
group: ${{ github.event.repository.name }}-dev-env
4848
cancel-in-progress: false
4949
environment: "AWS DEV"
50-
name: Deploy to DEV
50+
name: Deploy to DEV and Run Tests
5151
needs:
5252
- test-unit
5353
steps:
@@ -90,38 +90,6 @@ jobs:
9090
HUSKY: "0"
9191
VITE_RUN_ENVIRONMENT: dev
9292

93-
test-dev:
94-
runs-on: ubuntu-latest
95-
name: Run Live Tests
96-
needs:
97-
- deploy-dev
98-
concurrency:
99-
group: ${{ github.event.repository.name }}-dev-env
100-
cancel-in-progress: false
101-
steps:
102-
- uses: actions/checkout@v4
103-
env:
104-
HUSKY: "0"
105-
cache: 'yarn'
106-
107-
- name: Set up Node
108-
uses: actions/setup-node@v4
109-
with:
110-
node-version: 22.x
111-
112-
- name: Restore Yarn Cache
113-
uses: actions/cache@v4
114-
with:
115-
path: node_modules
116-
key: yarn-modules-${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}-dev
117-
restore-keys: |
118-
yarn-modules-${{ runner.os }}-
119-
120-
- name: Set up Python 3.11 for testing
121-
uses: actions/setup-python@v5
122-
with:
123-
python-version: 3.11
124-
12593
- name: Run health check
12694
run: make dev_health_check
12795

.github/workflows/deploy-prod.yml

Lines changed: 5 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ jobs:
2424
python-version: 3.11
2525
- name: Run unit testing
2626
run: make test_unit
27-
deploy-dev:
27+
28+
deploy-test-dev:
2829
runs-on: ubuntu-latest
2930
concurrency:
3031
group: ${{ github.event.repository.name }}-dev
@@ -33,7 +34,7 @@ jobs:
3334
id-token: write
3435
contents: read
3536
environment: "AWS DEV"
36-
name: Deploy to DEV
37+
name: Deploy to DEV and Run Tests
3738
needs:
3839
- test-unit
3940
steps:
@@ -62,26 +63,6 @@ jobs:
6263
HUSKY: "0"
6364
VITE_RUN_ENVIRONMENT: dev
6465

65-
test-dev:
66-
runs-on: ubuntu-latest
67-
name: Run Live Tests
68-
needs:
69-
- deploy-dev
70-
concurrency:
71-
group: ${{ github.event.repository.name }}-dev
72-
cancel-in-progress: false
73-
steps:
74-
- name: Set up Node
75-
uses: actions/setup-node@v4
76-
with:
77-
node-version: 22.x
78-
- uses: actions/checkout@v4
79-
env:
80-
HUSKY: "0"
81-
- name: Set up Python 3.11 for testing
82-
uses: actions/setup-python@v5
83-
with:
84-
python-version: 3.11
8566
- name: Run live testing
8667
run: make test_live_integration
8768
env:
@@ -94,15 +75,15 @@ jobs:
9475

9576
deploy-prod:
9677
runs-on: ubuntu-latest
97-
name: Deploy to Prod
78+
name: Deploy to Prod and Run Health Check
9879
concurrency:
9980
group: ${{ github.event.repository.name }}-prod
10081
cancel-in-progress: false
10182
permissions:
10283
id-token: write
10384
contents: read
10485
needs:
105-
- test-dev
86+
- deploy-test-dev
10687
environment: "AWS PROD"
10788
steps:
10889
- name: Set up Node for testing
@@ -129,22 +110,5 @@ jobs:
129110
env:
130111
HUSKY: "0"
131112
VITE_RUN_ENVIRONMENT: prod
132-
133-
health-check-prod:
134-
runs-on: ubuntu-latest
135-
name: Confirm services healthy
136-
needs:
137-
- deploy-prod
138-
concurrency:
139-
group: ${{ github.event.repository.name }}-prod
140-
cancel-in-progress: false
141-
steps:
142-
- name: Set up Node for testing
143-
uses: actions/setup-node@v4
144-
with:
145-
node-version: 22.x
146-
- uses: actions/checkout@v4
147-
env:
148-
HUSKY: "0"
149113
- name: Call the health check script
150114
run: make prod_health_check

0 commit comments

Comments
 (0)