fix up cfn

Author: devksingh4

cloudformation/custom-domain.yml

@@ -40,6 +40,7 @@ Parameters:
 
 Conditions:
   IsProd: !Equals [!Ref RunEnvironment, "prod"]
+  IsDev: !Equals [!Ref RunEnvironment, "dev"]
   ShouldAttachVpc: !Equals [true, !Ref VpcRequired]
 
 Mappings:
@@ -106,35 +107,56 @@ Resources:
         QueueName: !Sub ${ApplicationPrefix}-sqs
         MessageTimeout: !Ref SqsMessageTimeout
 
-  IcalDomainProxy:
-    Type: AWS::Serverless::Application
-    Properties:
-      Location: ./custom-domain.yml
-      Parameters:
-        RunEnvironment: !Ref RunEnvironment
-        RecordName: ical
-        GWBaseDomainName: !FindInMap
-          - ApiGwConfig
-          - !Ref RunEnvironment
-          - EnvDomainName
-        GWHostedZoneId:
-          !FindInMap [ApiGwConfig, !Ref RunEnvironment, HostedZoneId]
-        CloudfrontDomain: !GetAtt [AppIcalCloudfrontDistribution, DomainName]
-
-  CoreUrlProd:
-    Type: AWS::Serverless::Application
+  LinkryRecordSet:
+    Condition: IsDev
+    Type: AWS::Route53::RecordSet
     Properties:
-      Location: ./custom-domain.yml
-      Parameters:
-        RunEnvironment: !Ref RunEnvironment
-        RecordName: core
-        GWBaseDomainName: !FindInMap
-          - ApiGwConfig
-          - !Ref RunEnvironment
-          - EnvDomainName
-        GWHostedZoneId:
-          !FindInMap [ApiGwConfig, !Ref RunEnvironment, HostedZoneId]
-        CloudfrontDomain: !GetAtt [AppFrontendCloudfrontDistribution, DomainName]
+      HostedZoneId: !FindInMap [ApiGwConfig, !Ref RunEnvironment, HostedZoneId]
+      Name: !Join
+        - "."
+        - - "go"
+          - !FindInMap
+            - ApiGwConfig
+            - !Ref RunEnvironment
+            - EnvDomainName
+      Type: CNAME
+      TTL: '300'
+      ResourceRecords:
+        - !GetAtt [AppLinkryCloudfrontDistribution, DomainName]
+
+  IcalRecordSet:
+    Condition: IsDev
+    Type: AWS::Route53::RecordSet
+    Properties:
+      HostedZoneId: !FindInMap [ApiGwConfig, !Ref RunEnvironment, HostedZoneId]
+      Name: !Join
+        - "."
+        - - "ical"
+          - !FindInMap
+            - ApiGwConfig
+            - !Ref RunEnvironment
+            - EnvDomainName
+      Type: CNAME
+      TTL: '300'
+      ResourceRecords:
+        - !GetAtt [AppIcalCloudfrontDistribution, DomainName]
+
+  CoreRecordSet:
+    Condition: IsDev
+    Type: AWS::Route53::RecordSet
+    Properties:
+      HostedZoneId: !FindInMap [ApiGwConfig, !Ref RunEnvironment, HostedZoneId]
+      Name: !Join
+        - "."
+        - - "core"
+          - !FindInMap
+            - ApiGwConfig
+            - !Ref RunEnvironment
+            - EnvDomainName
+      Type: CNAME
+      TTL: '300'
+      ResourceRecords:
+        - !GetAtt [AppFrontendCloudfrontDistribution, DomainName]
 
   AppLambdaUrl:
     Type: AWS::Lambda::Url
@@ -912,21 +934,6 @@ Resources:
           SslSupportMethod: sni-only
         PriceClass: PriceClass_100
 
-  LinkryDomainProxy:
-    Type: AWS::Serverless::Application
-    Properties:
-      Location: ./custom-domain.yml
-      Parameters:
-        RunEnvironment: !Ref RunEnvironment
-        RecordName: go
-        GWBaseDomainName: !FindInMap
-          - ApiGwConfig
-          - !Ref RunEnvironment
-          - EnvDomainName
-        GWHostedZoneId:
-          !FindInMap [ApiGwConfig, !Ref RunEnvironment, HostedZoneId]
-        CloudfrontDomain: !GetAtt [AppLinkryCloudfrontDistribution, DomainName]
-
 Outputs:
   DomainName:
     Description: Domain name that the UI is hosted at