fix tests

Author: devksingh4

tests/unit/auth.test.ts

@@ -19,19 +19,12 @@ const ddbMock = mockClient(SecretsManagerClient);
 
 const app = await init();
 const jwt_secret = secretObject["jwt_key"];
-export function createJwt(
-  date?: Date,
-  group?: string,
-  email?: string,
-  roles?: string[], // Add roles parameter
-) {
+export function createJwt(date?: Date, group?: string, email?: string) {
   let modifiedPayload = {
     ...jwtPayload,
     email: email || jwtPayload.email,
     groups: [...jwtPayload.groups],
-    roles: roles || jwtPayload.roles, // Use provided roles or default roles
   };
-
   if (date) {
     const nowMs = Math.floor(date.valueOf() / 1000);
     const laterMs = nowMs + 3600 * 24;
@@ -44,9 +37,8 @@ export function createJwt(
   }
 
   if (group) {
-    modifiedPayload.groups[0] = group;
+    modifiedPayload.groups = [group];
   }
-
   return jwt.sign(modifiedPayload, jwt_secret, { algorithm: "HS256" });
 }
 

tests/unit/linkry.test.ts

@@ -1,8 +1,6 @@
-import { afterAll, expect, test, beforeEach, vi } from "vitest";
+import { expect, test, vi } from "vitest";
 import {
   DynamoDBClient,
-  PutItemCommand,
-  GetItemCommand,
   ScanCommand,
   QueryCommand,
   TransactWriteItemsCommand,
@@ -50,125 +48,68 @@ smMock.on(GetSecretValueCommand).resolves({
   SecretString: secretJson,
 });
 
-const testJwt = createJwt(
-  undefined, // No specific date
-  undefined, // No specific group
-  "[email protected]", // Test email
-  ["AppRoles.LINKS_MANAGER", "AppRoles.LINKS_ADMIN"], // Add required roles
-);
+const testJwt = createJwt(undefined, "0", "[email protected]");
 
 test("Happy path: Fetch all linkry redirects with proper roles", async () => {
-  // Create a test JWT with roles
-
-  // Mock successful DynamoDB operations
   ddbMock.on(QueryCommand).resolves({
-    Items: [], // Simulate no existing records
+    Items: [],
   });
 
-  // Make the request to the /api/v1/linkry/redir endpoint
+  ddbMock
+    .on(ScanCommand)
+    .resolvesOnce({
+      Items: [],
+    })
+    .rejects();
+
   const response = await app.inject({
     method: "GET",
     url: "/api/v1/linkry/redir",
     headers: {
-      Authorization: `Bearer ${testJwt}`, // Include the JWT with roles
+      Authorization: `Bearer ${testJwt}`,
     },
   });
 
   expect(response.statusCode).toBe(200);
 });
 
-//2. Create a new link using supertest
-// const eventResponse = await supertest(app.server)
-//   .post("/api/v1/linkry/redir/")
-//   .set("Authorization", `Bearer ${testJwt}`)
-//   .send({
-//     description: "Test event for ETag verification",
-//     host: "Social Committee",
-//     location: "Siebel Center",
-//     start: "2024-09-25T18:00:00",
-//     title: "ETag Test Event",
-//     featured: false,
-//   });
-
-// expect(eventResponse.statusCode).toBe(201);
-// const eventId = eventResponse.body.id;
-
-// test("Happy path: Create or update a linkry redirect", async () => {
-//   // Mock successful DynamoDB operations
-//   ddbMock.on(QueryCommand).resolves({
-//     Items: [], // Simulate no existing records for the slug
-//   });
-
-//   // Define the request payload
-//   const payload = {
-//     access: [],
-//     counter: 0,
-//     isEdited: true,
-//     redirect: "https://www.rainbow.com",
-//     slug: "bQjryt",
-//   };
-
-//   // Make the request to the /api/v1/linkry/redir/ endpoint
-//   const response = await supertest(app.server)
-//     .post("/api/v1/linkry/redir/")
-//     .set("Authorization", `Bearer ${testJwt}`) // Add authorization header
-//     .send(payload); // Send the payload
-
-//   // Assert the response status code
-//   expect(response.statusCode).toBe(201);
-
-//   // Assert the response body (optional, based on your API's response structure)
-//   expect(response.body).toStrictEqual({
-//     message: "Linkry redirect created or updated successfully",
-//     slug: "bQjryt",
-//   });
-// });
+test("Make sure that a DB scan is only called for admins", async () => {
+  const testManagerJwt = createJwt(undefined, "999", "[email protected]");
+
+  ddbMock.on(QueryCommand).resolves({
+    Items: [],
+  });
+
+  ddbMock.on(ScanCommand).rejects();
+
+  const response = await app.inject({
+    method: "GET",
+    url: "/api/v1/linkry/redir",
+    headers: {
+      Authorization: `Bearer ${testManagerJwt}`,
+    },
+  });
+
+  expect(response.statusCode).toBe(200);
+});
 
 test("Happy path: Create a new linkry redirect", async () => {
-  // Mock successful DynamoDB operations
   ddbMock.on(QueryCommand).resolves({
-    Items: [], // Simulate no existing records for the slug
+    Items: [],
   });
 
-  ddbMock.on(TransactWriteItemsCommand).resolves({}); // Simulate successful insertion
+  ddbMock.on(TransactWriteItemsCommand).resolves({});
 
-  // Define the request payload
   const payload = {
     access: [],
-    counter: 0,
-    isEdited: true,
     redirect: "https://www.acm.illinois.edu/",
     slug: "acm-test-slug",
   };
 
-  // Make the request to the /api/v1/linkry/redir/ endpoint
   const response = await supertest(app.server)
     .post("/api/v1/linkry/redir")
-    .set("Authorization", `Bearer ${testJwt}`) // Include the JWT with roles
-    .send(payload); // Send the payload
+    .set("Authorization", `Bearer ${testJwt}`)
+    .send(payload);
 
-  // Assert the response status code
   expect(response.statusCode).toBe(201);
 });
-
-// const testAdminJwt = createJwt(undefined, "LINKS_ADMIN");
-// const testAccessDeniedJwt = createJwt(undefined, "1");
-
-// const adminLinkryResponse = await app.inject({
-//   method: "GET",
-//   url: "/api/v1/linkry/redir",
-//   headers: {
-//     Authorization: `Bearer ${testAdminJwt}`,
-//   },
-// });
-
-// const accessDeniedLinkryResponse = await app.inject({
-//   method: "GET",
-//   url: "/api/v1/linkry/redir",
-//   headers: {
-//     Authorization: `Bearer ${testAccessDeniedJwt}`,
-//   },
-// });
-
-// expect(adminLinkryResponse.statusCode).toBe(200);
-// expect(accessDeniedLinkryResponse.statusCode).toBe(401);

tests/unit/vitest.setup.ts

@@ -44,6 +44,7 @@ vi.mock(
           "1": [],
           LINKS_ADMIN: [AppRoles.LINKS_ADMIN],
           "scanner-only": [AppRoles.TICKETS_SCANNER],
+          "999": [AppRoles.LINKS_MANAGER],
         };
 
         return mockGroupRoles[groupId] || [];