fix sqs send policy

devksingh4 · devksingh4 · commit c8bb228b5663 · 2025-07-27T02:45:54.000-04:00
diff --git a/terraform/modules/lambdas/main.tf b/terraform/modules/lambdas/main.tf
@@ -119,7 +119,7 @@ resource "aws_iam_policy" "api_only_policy" {
         Effect = "Allow",
         Action = ["sqs:SendMessage"],
         Resource = [
-          "arn:aws:sqs:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:infra-core-api-*",
+          "arn:aws:sqs:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:${var.ProjectId}-*",
         ]
       }
     ]
@@ -294,8 +294,9 @@ resource "aws_iam_policy" "shared_iam_policy" {
 }
 
 resource "aws_iam_role_policy_attachment" "api_attach" {
+  for_each   = toset([aws_iam_policy.shared_iam_policy.arn, aws_iam_policy.api_only_policy.arn])
   role       = aws_iam_role.api_role.name
-  policy_arn = aws_iam_policy.shared_iam_policy.arn
+  policy_arn = each.key
 }
 
 resource "aws_iam_role_policy_attachment" "entra_attach" {

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ resource "aws_iam_policy" "api_only_policy" {`
`119`	`119`	`Effect = "Allow",`
`120`	`120`	`Action = ["sqs:SendMessage"],`
`121`	`121`	`Resource = [`
`122`		`- "arn:aws:sqs:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:infra-core-api-*",`
	`122`	`+ "arn:aws:sqs:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:${var.ProjectId}-*",`
`123`	`123`	`]`
`124`	`124`	`}`
`125`	`125`	`]`
`@@ -294,8 +294,9 @@ resource "aws_iam_policy" "shared_iam_policy" {`
`294`	`294`	`}`
`295`	`295`
`296`	`296`	`resource "aws_iam_role_policy_attachment" "api_attach" {`
	`297`	`+ for_each = toset([aws_iam_policy.shared_iam_policy.arn, aws_iam_policy.api_only_policy.arn])`
`297`	`298`	`role = aws_iam_role.api_role.name`
`298`		`- policy_arn = aws_iam_policy.shared_iam_policy.arn`
	`299`	`+ policy_arn = each.key`
`299`	`300`	`}`
`300`	`301`
`301`	`302`	`resource "aws_iam_role_policy_attachment" "entra_attach" {`