fixes part 3

Author: devksingh4

src/api/routes/roomRequests.ts

@@ -251,8 +251,8 @@ const roomRequestRoutes: FastifyPluginAsync = async (fastify, _options) => {
         },
         payload: {
           to: [notificationRecipients[fastify.runEnvironment].OfficerBoard],
-          subject: "A new room request has been created",
-          content: `${request.username} created a room reservation request. Please log into the ACM management portal for more information.\n\n\nACM @ UIUC Core`,
+          subject: "New Room Reservation Request",
+          content: `A new room reservation request has been created (${request.body.host} | ${request.body.title}). Please visit https://${fastify.environmentConfig["UserFacingUrl"]}/roomRequests/${request.body.semester}/${requestId} to view details.`,
         },
       };
       if (!fastify.sqsClient) {

src/api/sqs/emailNotifications.ts

@@ -15,7 +15,7 @@ export const emailNotificationsHandler: SQSHandlerFunction<
   AvailableSQSFunctions.EmailNotifications
 > = async (payload, metadata, logger) => {
   const { to, cc, bcc, content, subject } = payload;
-  const senderEmail = `notifications@${currentEnvironmentConfig["EmailDomain"]}`;
+  const senderEmail = `ACM @ UIUC <notifications@${currentEnvironmentConfig["EmailDomain"]}>`;
   logger.info("Constructing email...");
   const command = new SendEmailCommand({
     Source: senderEmail,

src/common/config.ts

@@ -9,6 +9,7 @@ type ValueOrArray<T> = T | ArrayOfValueOrArray<T>;
 type AzureRoleMapping = Record<string, readonly AppRoles[]>;
 
 export type ConfigType = {
+  UserFacingUrl: string;
   AzureRoleMapping: AzureRoleMapping;
   ValidCorsOrigins: ValueOrArray<OriginType> | OriginFunction;
   AadValidClientId: string;
@@ -80,6 +81,7 @@ const genericConfig: GenericConfigType = {
 
 const environmentConfig: EnvironmentConfigType = {
   dev: {
+    UserFacingUrl: "https://core.aws.qa.acmuiuc.org",
     AzureRoleMapping: { AutonomousWriters: [AppRoles.EVENTS_MANAGER] },
     ValidCorsOrigins: [
       "https://merch-pwa.pages.dev",
@@ -99,6 +101,7 @@ const environmentConfig: EnvironmentConfigType = {
     PaidMemberPriceId: "price_1R4TcTDGHrJxx3mKI6XF9cNG",
   },
   prod: {
+    UserFacingUrl: "https://core.acm.illinois.edu",
     AzureRoleMapping: { AutonomousWriters: [AppRoles.EVENTS_MANAGER] },
     ValidCorsOrigins: [
       /^https:\/\/(?:.*\.)?acmuiuc-academic-web\.pages\.dev$/,