fix rendering and notifications

Author: devksingh4

src/api/routes/roomRequests.ts

@@ -316,7 +316,7 @@ const roomRequestRoutes: FastifyPluginAsync = async (fastify, _options) => {
         payload: {
           to: [notificationRecipients[fastify.runEnvironment].OfficerBoard],
           subject: "New Room Reservation Request",
-          content: `A new room reservation request has been created (${request.body.host} | ${request.body.title}). Please visit https://${fastify.environmentConfig["UserFacingUrl"]}/roomRequests/${request.body.semester}/${requestId} to view details.`,
+          content: `A new room reservation request has been created (${request.body.host} | ${request.body.title}). Please visit ${fastify.environmentConfig["UserFacingUrl"]}/roomRequests/${request.body.semester}/${requestId} to view details.`,
         },
       };
       if (!fastify.sqsClient) {

src/common/types/roomRequest.ts

@@ -155,11 +155,11 @@ export const roomRequestBaseSchema = z.object({
 
 export const roomRequestSchema = roomRequestBaseSchema
   .extend({
-    eventStart: z.date({
+    eventStart: z.coerce.date({
       required_error: "Event start date and time is required",
       invalid_type_error: "Event start must be a valid date and time",
     }),
-    eventEnd: z.date({
+    eventEnd: z.coerce.date({
       required_error: "Event end date and time is required",
       invalid_type_error: "Event end must be a valid date and time",
     }),
@@ -184,17 +184,17 @@ export const roomRequestSchema = roomRequestBaseSchema
     // Existing fields
     hostingMinors: z.boolean(),
     locationType: z.enum(["in-person", "virtual", "both"]),
-    spaceType: z.string(),
-    specificRoom: z.string().optional(),
+    spaceType: z.string().min(1),
+    specificRoom: z.string().min(1),
     estimatedAttendees: z.number().positive(),
-    seatsNeeded: z.number().positive().optional(),
-    setupDetails: z.string().nullable().optional(),
-    onCampusPartners: z.string().nullable(),
-    offCampusPartners: z.string().nullable(),
-    nonIllinoisSpeaker: z.string().nullable(),
-    nonIllinoisAttendees: z.number().nullable(),
-    foodOrDrink: z.boolean().nullable(),
-    crafting: z.boolean().nullable(),
+    seatsNeeded: z.number().positive(),
+    setupDetails: z.string().min(1).nullable().optional(),
+    onCampusPartners: z.string().min(1).nullable(),
+    offCampusPartners: z.string().min(1).nullable(),
+    nonIllinoisSpeaker: z.string().min(1).nullable(),
+    nonIllinoisAttendees: z.number().min(1).nullable(),
+    foodOrDrink: z.boolean(),
+    crafting: z.boolean(),
     comments: z.string().optional(),
   })
   .refine(

src/ui/pages/roomRequest/NewRoomRequest.tsx

@@ -316,7 +316,16 @@ const NewRoomRequest: React.FC<NewRoomRequestProps> = ({
         return;
       }
       setIsSubmitting(true);
-      const values = await roomRequestSchema.parseAsync(apiFormValues);
+      let values;
+      try {
+        values = await roomRequestSchema.parseAsync(apiFormValues);
+      } catch (e) {
+        notifications.show({
+          title: 'Submission failed to validate',
+          message: 'Check the browser console for more details.',
+        });
+        throw e;
+      }
       const response = await createRoomRequest(values);
       notifications.show({
         title: 'Room Request Submitted',

src/ui/pages/roomRequest/ViewRoomRequest.page.tsx

@@ -19,6 +19,7 @@ import { useApi } from '@ui/util/api';
 import NewRoomRequest from './NewRoomRequest';
 import {
   RoomRequestGetResponse,
+  roomRequestSchema,
   RoomRequestStatus,
   RoomRequestStatusUpdatePostBody,
 } from '@common/types/roomRequest';
@@ -48,7 +49,11 @@ export const ViewRoomRequest: React.FC = () => {
   };
   const updateData = async () => {
     const response = await api.get(`/api/v1/roomRequests/${semesterId}/${requestId}`);
-    setData(response.data);
+    const parsed = {
+      data: await roomRequestSchema.parseAsync(response.data.data),
+      updates: response.data.updates,
+    };
+    setData(parsed);
   };
   const submitStatusChange = async () => {
     try {