fix env prioritization

devksingh4 · devksingh4 · commit e93df83b03f6 · 2025-01-10T15:27:14.000-06:00
diff --git a/e2e/base.ts b/e2e/base.ts
@@ -30,8 +30,8 @@ async function getSecrets() {
   if (!process.env.PLAYWRIGHT_USERNAME || !process.env.PLAYWRIGHT_PASSWORD) {
     keyData = await getSecretValue('infra-core-api-config')
   }
-  response['PLAYWRIGHT_USERNAME'] = process.env.PLAYWRIGHT_USERNAME || keyData ? keyData['playwright_username'] : '';
-  response['PLAYWRIGHT_PASSWORD'] = process.env.PLAYWRIGHT_PASSWORD || keyData ? keyData['playwright_password'] : '';
+  response['PLAYWRIGHT_USERNAME'] = process.env.PLAYWRIGHT_USERNAME || (keyData ? keyData['playwright_username'] : '');
+  response['PLAYWRIGHT_PASSWORD'] = process.env.PLAYWRIGHT_PASSWORD || (keyData ? keyData['playwright_password'] : '');
   return response;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,8 @@ async function getSecrets() {`
`30`	`30`	`if (!process.env.PLAYWRIGHT_USERNAME \|\| !process.env.PLAYWRIGHT_PASSWORD) {`
`31`	`31`	`keyData = await getSecretValue('infra-core-api-config')`
`32`	`32`	`}`
`33`		`- response['PLAYWRIGHT_USERNAME'] = process.env.PLAYWRIGHT_USERNAME \|\| keyData ? keyData['playwright_username'] : '';`
`34`		`- response['PLAYWRIGHT_PASSWORD'] = process.env.PLAYWRIGHT_PASSWORD \|\| keyData ? keyData['playwright_password'] : '';`
	`33`	`+ response['PLAYWRIGHT_USERNAME'] = process.env.PLAYWRIGHT_USERNAME \|\| (keyData ? keyData['playwright_username'] : '');`
	`34`	`+ response['PLAYWRIGHT_PASSWORD'] = process.env.PLAYWRIGHT_PASSWORD \|\| (keyData ? keyData['playwright_password'] : '');`
`35`	`35`	`return response;`
`36`	`36`	`}`
`37`	`37`