Skip to content

Commit 555753a

Browse files
Merge pull request #15 from acompany-develop/chore/add-doc-comments
docs: refine README wording and add missing client doc comments
2 parents e109928 + 46a406d commit 555753a

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

README.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
![MSRV](https://img.shields.io/badge/MSRV-1.90.0-blue)
55
[![License](https://img.shields.io/badge/License-MIT-red)](/LICENSE)
66

7-
This repository demonstrates a simple end-to-end flow against an AWS Nitro Enclave: **ECDH key exchange & attestation verification → confidential computation (example: adding two integers)**.
7+
This repository demonstrates a simple end-to-end flow against an AWS Nitro Enclave: **ECDH key exchange & attestation verification → confidential computing (example: adding two integers)**.
88

99
- **Parent VM**: An AWS EC2 instance (Ubuntu 24.04) with Nitro Enclaves enabled. Runs the Enclave and the vsock proxy.
1010
- **Client**: Can run on any machine.
@@ -14,7 +14,7 @@ This repository demonstrates a simple end-to-end flow against an AWS Nitro Encla
1414
### Server (Parent VM)
1515

1616
- **Cloud Platform**: AWS
17-
- **Instance type**: any Nitro Enclaves capable instance
17+
- **Instance type**: any Nitro Enclaves capable EC2 instance
1818
- See [Parent instance requirements](https://docs.aws.amazon.com/enclaves/latest/user/nitro-enclave.html#nitro-enclave-reqs)
1919
- Both x86_64 and AArch64 are supported
2020
- **AMI**: Ubuntu Server 24.04 LTS
@@ -28,7 +28,7 @@ The client code is architecture-independent. Ideally, it should be usable in any
2828

2929
Tested on the Parent VM environments listed below. For ease of testing, the Server (vsock proxy) runs on localhost (`127.0.0.1:8080`) on the Parent VM, and the Client also runs on the same Parent VM.
3030

31-
### Parent VM (AWS EC2)
31+
### Parent VM (AWS EC2 instance)
3232

3333
#### Ubuntu 24.04 (x86_64)
3434

@@ -62,10 +62,6 @@ Tested on the Parent VM environments listed below. For ease of testing, the Serv
6262
- **Allocated vCPUs**: 2
6363
- **Allocated Memory**: 512 MiB
6464

65-
### Client
66-
67-
Same as the parent VM.
68-
6965
## Architecture
7066

7167
- `enclave/`: Enclave application (listens on vsock port)

client/src/crypto.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// SPDX-License-Identifier: MIT
22

3+
//! Cryptographic helpers for the client protocol.
4+
35
use anyhow::{Result, anyhow};
46
use aws_lc_rs::rand::SecureRandom;
57
use aws_lc_rs::{aead, digest, hmac, rand};

client/src/main.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// SPDX-License-Identifier: MIT
22

3+
//! This is the main client program.
4+
35
use anyhow::{Result, anyhow};
46
use p256::elliptic_curve::rand_core::OsRng;
57
use p256::{EncodedPoint, PublicKey, SecretKey, ecdh::diffie_hellman};

client/src/types.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// SPDX-License-Identifier: MIT
22

3+
//! This module provides public types.
4+
35
use anyhow::Result;
46
use serde::{Deserialize, Serialize};
57

0 commit comments

Comments
 (0)