Add build date, exclude old bugsnag reports (#1954)

* Add build date, exclude old bugsnag reports

* Update src/Helpers/TelemetryHelper.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* extract build date

* fix tests

* add test

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: danepowell

.github/workflows/ci.yml

@@ -95,6 +95,7 @@ jobs:
           echo BUGSNAG_KEY=${{ secrets.BUGSNAG_KEY }} >> .env
           echo AMPLITUDE_KEY=${{ secrets.AMPLITUDE_KEY }} >> .env
           echo ACLI_VERSION=${{ steps.acli-version.outputs.ACLI_VERSION }} >> .env
+          echo ACLI_BUILD_DATE=$(date -u +"%Y-%m-%dT%H:%M:%SZ") >> .env
       - name: Build
         run: |
           composer install --no-dev --optimize-autoloader

bin/acli

@@ -81,6 +81,7 @@ if (in_array($input->getFirstArgument(), ['clear-kernel-cache', 'ckc'])) {
 putenv('BUGSNAG_KEY=');
 putenv('AMPLITUDE_KEY=');
 putenv('ACLI_VERSION=dev-unknown');
+putenv('ACLI_BUILD_DATE=1970-01-01T00:00:00Z');
 $dotenv = Dotenv::createUnsafeMutable(__DIR__ . '/..');
 $dotenv->safeLoad();
 

src/Application.php

@@ -17,6 +17,8 @@ class Application extends \Symfony\Component\Console\Application
      */
     protected array $helpMessages = [];
 
+    protected ?string $buildDate = null;
+
     /**
      * @return string[]
      */
@@ -43,4 +45,13 @@ public function renderThrowable(
             $io->block($this->getHelpMessages(), 'help', 'help', ' ', true, false);
         }
     }
+
+    public function getBuildDate(): ?string
+    {
+        if ($this->buildDate !== null) {
+            return $this->buildDate;
+        }
+        $this->buildDate = getenv('ACLI_BUILD_DATE') ?: null;
+        return $this->buildDate;
+    }
 }

src/Command/CommandBase.php

@@ -235,8 +235,11 @@ protected function initialize(InputInterface $input, OutputInterface $output): v
         );
         $this->formatter = $this->getHelper('formatter');
 
-        $this->output->writeln('Acquia CLI version: ' . $this->getApplication()
-            ->getVersion(), OutputInterface::VERBOSITY_DEBUG);
+        $application = $this->getApplication();
+        $version = ($application && method_exists($application, 'getVersion')) ? $application->getVersion() : null;
+        $this->output->writeln('Acquia CLI version: ' . ($version ?? 'unknown'), OutputInterface::VERBOSITY_DEBUG);
+        $buildDate = ($application && method_exists($application, 'getBuildDate')) ? $application->getBuildDate() : null;
+        $this->output->writeln('Build date: ' . ($buildDate ?? 'unknown'), OutputInterface::VERBOSITY_DEBUG);
         $this->output->writeln('PHP runtime: ' . PHP_SAPI, OutputInterface::VERBOSITY_DEBUG);
         if (getenv('ACLI_NO_TELEMETRY') !== 'true') {
             $this->checkAndPromptTelemetryPreference();

src/Command/Self/SelfInfoCommand.php

@@ -17,7 +17,11 @@ final class SelfInfoCommand extends CommandBase
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $table = $this->createTable($output, 'Acquia CLI information', ['Property', 'Value']);
-        $table->addRow(['Version', $this->getApplication()->getVersion()]);
+        $application = $this->getApplication();
+        $version = ($application && method_exists($application, 'getVersion')) ? $application->getVersion() : null;
+        $table->addRow(['Version', $version ?? 'unknown']);
+        $buildDate = ($application && method_exists($application, 'getBuildDate')) ? $application->getBuildDate() : null;
+        $table->addRow(['Build date', $buildDate ?? 'unknown']);
         $table->addRow(['Cloud datastore', $this->datastoreCloud->filepath]);
         $table->addRow(['ACLI datastore', $this->datastoreAcli->filepath]);
         $table->addRow(['Telemetry enabled', var_export($this->telemetryHelper->telemetryEnabled(), true)]);

src/Helpers/TelemetryHelper.php

@@ -34,6 +34,28 @@ public function initialize(): void
         $this->initializeBugsnag();
     }
 
+    /**
+     * Checks if the build date is older than the given number of months.
+     *
+     * @param string|null $buildDate The build date string (any strtotime-compatible format).
+     * @param int $months Number of months to compare.
+     * @param int|null $now Optional timestamp to use as 'now' (for testing).
+     * @return bool True if build date is older than given months, false otherwise.
+     */
+    public static function isBuildDateOlderThanMonths(?string $buildDate, int $months, ?int $now = null): bool
+    {
+        if (!$buildDate) {
+            return false;
+        }
+        $buildTimestamp = strtotime($buildDate);
+        if ($buildTimestamp === false) {
+            return false;
+        }
+        $now = $now ?? time();
+        $interval = 60 * 60 * 24 * 30 * $months;
+        return ($now - $buildTimestamp) > $interval;
+    }
+
     public function initializeBugsnag(): void
     {
         if (empty($this->bugSnagKey)) {
@@ -42,6 +64,12 @@ public function initializeBugsnag(): void
         if (!$this->telemetryEnabled()) {
             return;
         }
+        // Check build date: suppress Bugsnag if more than 3 months old.
+        $buildDate = $this->application->getBuildDate();
+        if (self::isBuildDateOlderThanMonths($buildDate, 3)) {
+            // Too old, do not send Bugsnag reports.
+            return;
+        }
         // It's safe-ish to make this key public.
         // @see https://github.com/bugsnag/bugsnag-js/issues/595
         $bugsnag = Client::make($this->bugSnagKey);
@@ -151,12 +179,12 @@ public function getTelemetryUserData(): array
     {
         $data = [
             'ah_app_uuid' => getenv('AH_APPLICATION_UUID'),
-            'ah_env' => $this->normalizeAhEnv(AcquiaDrupalEnvironmentDetector::getAhEnv()),
+            'ah_env' => self::normalizeAhEnv(AcquiaDrupalEnvironmentDetector::getAhEnv()),
             'ah_group' => AcquiaDrupalEnvironmentDetector::getAhGroup(),
             'ah_non_production' => getenv('AH_NON_PRODUCTION'),
             'ah_realm' => getenv('AH_REALM'),
             'CI' => getenv('CI'),
-            'env_provider' => $this->getEnvironmentProvider(),
+            'env_provider' => self::getEnvironmentProvider(),
             'php_version' => PHP_MAJOR_VERSION . '.' . PHP_MINOR_VERSION,
         ];
         try {

tests/phpunit/src/Commands/Self/SelfInfoCommandTest.php

@@ -29,6 +29,7 @@ public function testSelfInfoCommand(): void
         $this->assertStringContainsString('Property', $output);
         $this->assertStringContainsString('--------', $output);
         $this->assertStringContainsString('Version', $output);
+        $this->assertStringContainsString('Build date', $output);
         $this->assertStringContainsString('Cloud datastore', $output);
         $this->assertStringContainsString('ACLI datastore', $output);
         $this->assertStringContainsString('Telemetry enabled', $output);

tests/phpunit/src/Misc/TelemetryHelperTest.php

@@ -108,4 +108,28 @@ public function testAhEnvNormalization(string $ah_env, string $expected): void
         $normalized_ah_env = TelemetryHelper::normalizeAhEnv($ah_env);
         $this->assertEquals($expected, $normalized_ah_env);
     }
+
+    public function testIsBuildDateOlderThanMonthsNullDate(): void
+    {
+        $this->assertFalse(TelemetryHelper::isBuildDateOlderThanMonths(null, 3));
+    }
+
+    public function testIsBuildDateOlderThanMonthsInvalidDate(): void
+    {
+        $this->assertFalse(TelemetryHelper::isBuildDateOlderThanMonths('not-a-date', 3));
+    }
+
+    public function testIsBuildDateOlderThanMonthsRecentDate(): void
+    {
+        $now = strtotime('2026-01-12');
+        $buildDate = date('Y-m-d', strtotime('-2 months', $now));
+        $this->assertFalse(TelemetryHelper::isBuildDateOlderThanMonths($buildDate, 3, $now));
+    }
+
+    public function testIsBuildDateOlderThanMonthsOldDate(): void
+    {
+        $now = strtotime('2026-01-12');
+        $buildDate = date('Y-m-d', strtotime('-4 months', $now));
+        $this->assertTrue(TelemetryHelper::isBuildDateOlderThanMonths($buildDate, 3, $now));
+    }
 }