Automatically sanitize /botbalance arg

theonlypwner · theonlypwner · commit 6ef544a0736b · 2016-01-01T21:46:55.000-07:00
diff --git a/source/src/serveractions.h b/source/src/serveractions.h
@@ -315,8 +315,8 @@ struct botbalanceaction : serveraction
 {
     int balance;
     void perform() { botbalance = balance; checkai(); /* botbalance changed */ }
-    bool isvalid() { return balance >= -9999 && balance <= MAXCLIENTS; }
-    botbalanceaction(int balance) : balance(balance)
+    bool isvalid() { return true /*balance >= -9999 && balance <= MAXCLIENTS*/; }
+    botbalanceaction(int balance) : balance(clamp(balance, -9999, MAXCLIENTS))
     {
         reqcall = roleconf('a');
         reqveto = CR_MASTER; // botbalance

Original file line number	Diff line number	Diff line change
`@@ -315,8 +315,8 @@ struct botbalanceaction : serveraction`
`315`	`315`	`{`
`316`	`316`	`int balance;`
`317`	`317`	`void perform() { botbalance = balance; checkai(); /* botbalance changed */ }`
`318`		`- bool isvalid() { return balance >= -9999 && balance <= MAXCLIENTS; }`
`319`		`- botbalanceaction(int balance) : balance(balance)`
	`318`	`+ bool isvalid() { return true /balance >= -9999 && balance <= MAXCLIENTS/; }`
	`319`	`+ botbalanceaction(int balance) : balance(clamp(balance, -9999, MAXCLIENTS))`
`320`	`320`	`{`
`321`	`321`	`reqcall = roleconf('a');`
`322`	`322`	`reqveto = CR_MASTER; // botbalance`