-
-
Notifications
You must be signed in to change notification settings - Fork 14
Description
Here is some early feedback on your documentation. First - I'd recommend having it rendered via readthedocs (or sphinx locally) and remove it from your branded website. The format of this site and navigation is hard to read, and it's distracting to be alongside your profile, about, and basically many prompts to ask for funding. The project should stand alone on its own site. For example, for our flux projects we use a GitHub pages rendered mkdocs template (e.g.,).
For your blog post, in response to this line:
I was pleasantly surprised at how close each of the individual simulation runs were to each other.
I think this reflects your sampling. A "real world" collection of data from, for example, an autoscaler, is going to vary between times that you run it. Typically for experiments we will do multiple iterations of these real world runs, and then generate samples using that. There should be some variation in the individual simulation runs because we know there is in real clusters. It's a red flag that there is not. My suggestion is to run the real studies a few times to assess this and then have the simulation reflect that.
For the first part of the tutorial you tell the reader to git clone, but you don't give them the repository or a command. I think that the tutorial should have the git clone - people generally will want to copy paste it.
For the make build it's not clear to the reader that cargo is required. make build will likely fail for a large subset. You should explain that / link to instructions to install it. Here is what happened for me:
I saw it coming because I looked at the Makefile, but ran it anyway to show you the result.
For this part (the end of installation): https://appliedcomputing.io/simkube/docs/intro/installation/#customizing-simkube
You don't give the reader any context about where/when to apply these. It's not clear what is optional vs. required, and what files I'd write and how to apply. It's not clear if they are entire files or pieces. If this is a getting started / install, my desire would be for it to walk me through a full setup, be clear about what I need to do, and then provide the full files. My instinct is to do nothing, but maybe I'll end up with a borked tool?
I also have no idea where to go at the end of this page - it just stops. If I go to what I think is the next section:
https://appliedcomputing.io/simkube/docs/intro/running/
I'm supposedly supposed to start with having pods in the simkube namespace? I do not, and I'm not sure how they get there. So this is my stopping point for now. Let me know if/when you get a chance to update, thank you!
