Skip to content

Commit 2c19d87

Browse files
committed
refactor(container): rename containerFluidMargin to containerMargin and update related styles and stories
1 parent f70b6eb commit 2c19d87

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

example/src/components/primary/Container/Container.stories.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,10 @@ export const WithSpacerBreakpoints: Story = {
9595
};
9696

9797

98-
export const WithContainerFluidMargin: Story = {
98+
export const WithContainerMargin: Story = {
9999
decorators: (Story) => (
100100
<GridThemeProvider gridTheme={{
101-
containerFluidMargin: '20px',
101+
containerMargin: '20px',
102102
}}>
103103
<Story />
104104
</GridThemeProvider>
@@ -109,10 +109,10 @@ export const WithContainerFluidMargin: Story = {
109109
};
110110

111111

112-
export const WithContainerFluidMarginBreakpoints: Story = {
112+
export const WithContainerMarginBreakpoints: Story = {
113113
decorators: (Story) => (
114114
<GridThemeProvider gridTheme={{
115-
containerFluidMargin: {
115+
containerMargin: {
116116
xs: '40px',
117117
lg: '80px',
118118
},

src/GridSystem/Container/utils.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,30 +10,30 @@ import {IContainerProps, NoXsMediaSize,TStyledProps} from '../../types';
1010
* @param props
1111
*/
1212
export const createFluidBreakpoint = (props: TStyledProps<IContainerProps>) => {
13-
const containerFluidMargin = props.theme[themeName]?.containerFluidMargin;
13+
const containerMargin = props.theme[themeName]?.containerMargin;
1414

15-
if(!containerFluidMargin){
15+
if(!containerMargin){
1616
return undefined;
1717
}
1818

19-
if(typeof containerFluidMargin === 'string'){
19+
if(typeof containerMargin === 'string'){
2020
return `
21-
--acrool-container-fluid-padding: ${containerFluidMargin};
21+
--acrool-container-padding: ${containerMargin};
2222
`;
2323
}
2424

2525
return mediaSizes.reduce<string[]>((curr, sizeName) => {
2626

27-
const rwdContainerFluidMargin = containerFluidMargin[sizeName];
28-
if(rwdContainerFluidMargin){
27+
const rwdContainerMargin = containerMargin[sizeName];
28+
if(rwdContainerMargin){
2929
if(sizeName === 'xs'){
3030
return curr.concat(`
31-
--acrool-container-fluid-padding: ${rwdContainerFluidMargin};
31+
--acrool-container-padding: ${rwdContainerMargin};
3232
`);
3333
}
3434

3535
return curr.concat(media[sizeName]`
36-
--acrool-container-fluid-padding: ${rwdContainerFluidMargin};
36+
--acrool-container-padding: ${rwdContainerMargin};
3737
`);
3838
}
3939

src/styles.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,8 @@ $directions: (
258258
width: 100%;
259259
margin-right: auto;
260260
margin-left: auto;
261-
padding-right: calc((var(--acrool-gutter-x) * 0.5) + var(--acrool-container-fluid-padding, 0px));
262-
padding-left: calc((var(--acrool-gutter-x) * 0.5) + var(--acrool-container-fluid-padding, 0px));
261+
padding-right: calc((var(--acrool-gutter-x) * 0.5) + var(--acrool-container-padding, 0px));
262+
padding-left: calc((var(--acrool-gutter-x) * 0.5) + var(--acrool-container-padding, 0px));
263263
}
264264

265265
[data-grid="row"]{

src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export interface IGridThemeProviderProps {
7474

7575
export interface IGridSetting {
7676
spacer: TGutterWidth|Partial<IBreakpointsTGutterWidth>
77-
containerFluidMargin?: TGutterWidth|Partial<IBreakpointsTGutterWidth>
77+
containerMargin?: TGutterWidth|Partial<IBreakpointsTGutterWidth>
7878
gridColumns: number
7979
gridBreakpoints: IBreakpoints
8080
containerMaxWidths: TContainerMaxWidths

0 commit comments

Comments
 (0)