Code base familiarisation

[unsecretised]

How do i contribute to rift without any idea of the massive code base?

[unsecretised]

I've decided to run cargo doc --no-deps and then i'll slowly document bits, and then PR them since it is part of the roadmap

[acsandmann]

long term goal is to simplify interaction between reactor and children so bodies of event handlers get slimmer. and probably move certain things out of it to simplify. first state has to be centralized though so we can properly start to move things out and clean it up.

[unsecretised]

Oh ok.. do you want to switch to cargo workspaces as the first code cleanup?

[acsandmann]

thats definitely aine item for the future but maybe not right now. if you are looking for something to do, fixing the mission control bug should not be too bad and extending the menu icon so it has a menu tha allows you to toggle activation, quit, etc..

[unsecretised]

Regarding the menu icons, do you want to add a menu to the single icon, or do you want to make it so that each workspace gets an icon, and then you can click on each of the icons to switch workspaces, and then another rift menu bar icon which will be in charge of doing other things like toggling activation etc? Also, is there any specific reason you didn't use an external library like:
https://crates.io/crates/tray-icon
It makes life much easier in loading the tray icon, and you just need to store it as one of the fields in a struct that stays in the main thread throughout the life of the app.

[acsandmann]

imo there is almost no point in adding a library like that. objc2 provides enough "boilerplate" and i think the main benefit of such a library is easy cross platform but i have no intention to make rift cross platform so i don't really think i need it.

also, the menu icon in rift is actually done with minimal amounts of code. most of the code is dedicated towards drawing the status but i'm okay with that because its very low overhead and very performant which was a priority for something that could update frequently.

the only changes i really would like to make to the currently existing menu icon is that you can click it to either open Mission Control or show a menu that has toggle activation(maybe for each display/space?) and quit(maybe we can detect if its running in a service and provide both quit and restart).