Cargo workspaces #228
Replies: 2 comments 3 replies
-
|
i don't think thats exactly the best way to split rift with cargo workspaces. i would rather have like a main rift which still holds all the actors, maybe a ui library which holds the base of the menu icon, stack lines, and Mission Control, maybe a layout library since the layouts are all in theory stateless, and a platform library which holds all of our code that interfaces with macos. Just splitting the src folders into libraries is definitely a way to split it up but it doesnt feel that intuitive to me. |
Beta Was this translation helpful? Give feedback.
-
|
Factoring out platform-specific logic into a separate crate with ergonomic API would be super nifty! Then the crate can be re-used by different window managers, without having to reinvent the wheel 😺 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Why is rift a single crate and not a cargo workspace? Because i feel since @acsandmann has mentioned that the code base is a mess in #223 , it might be worth considering to do a "fairly tiny" (because there isn't much code change) in doing a switch to cargo workspaces. It can be part of the clean up. I have a bit of work done on this but then I realised this is a fairly big change and I don't want to work unnecesarily, and wanted other more experienced developer's input on this.
The work i have gotten done so far isn't a lot, but it can be viewed here
Beta Was this translation helpful? Give feedback.
All reactions