feat: Support for ox_core

TODO:
- Add config option for switching ESX/OX
- Add account creation logic

Author: antond15

client.lua

@@ -4,7 +4,7 @@ local uiOpened = false
 local isInBank = false
 
 local OpenBank = function(bank)
-	ESX.TriggerServerCallback('orp_banking:getBalance', function(balance)
+	lib.callback('orp_banking:getBalance', 100, function(balance)
 		uiOpened = true
 		isInBank = bank == true
 

config.lua

@@ -76,13 +76,11 @@ Config.BankZones = {
 
 SendNotify = function(msg, type)
 
-	TriggerEvent('mythic_notify:client:SendAlert', {								-- https://github.com/thelindat/mythic_notify
-		type = type,
+	exports.ox_inventory:notify({
 		text = msg,
-		length = 7500
+		type = type
 	})
 
-	-- ESX.ShowNotification(msg)													-- Default ESX notification
 	-- exports['t-notify']:Alert({ style = type, message = msg })					-- https://github.com/TasoOneAsia/t-notify
 
 end

fxmanifest.lua

@@ -7,9 +7,12 @@ description 'Banking script with qtarget support.'
 version '2.0.0'
 
 
-shared_script '@es_extended/imports.lua'
-server_script 'server.lua'
+shared_scripts {
+	'@ox_core/imports.lua',
+	'@ox_lib/init.lua'
+}
 
+server_script 'server.lua'
 client_scripts {
 	'config.lua',
 	'client.lua'

server.lua

@@ -1,62 +1,65 @@
-ESX.RegisterServerCallback('orp_banking:getBalance', function(source, cb)
-	local xPlayer = ESX.GetPlayerFromId(source)
-	cb(xPlayer and xPlayer.getAccount('bank').money or 0)
+local inventory = exports.ox_inventory
+
+lib.callback.register('orp_banking:getBalance', function(source)
+	local player = Player(source)
+	return player.getAccount('bank') or 0
 end)
 
 
 
 RegisterNetEvent('orp_banking:deposit', function(data)
-	local xPlayer = ESX.GetPlayerFromId(source)
+	local player = Player(source)
 	local amount = tonumber(data?.amount)
 
-	if not amount or amount <= 0 or amount > xPlayer.getMoney() then
-		TriggerClientEvent('orp_banking:notify', xPlayer.source, 'Invalid amount', 'error')
+	if not amount or amount <= 0 or amount > inventory:GetItem(source, 'money', false, true) then
+		TriggerClientEvent('orp_banking:notify', source, 'Invalid amount', 'error')
 	else
-		xPlayer.removeMoney(amount)
-		xPlayer.addAccountMoney('bank', amount)
-		TriggerClientEvent('orp_banking:update', xPlayer.source, xPlayer.getAccount('bank').money)
-		TriggerClientEvent('orp_banking:notify', xPlayer.source, 'You have successfully deposited $'.. amount, 'success')
+		inventory:RemoveItem(source, 'money', amount)
+		player.addAccount('bank', amount)
+		TriggerClientEvent('orp_banking:update', source, player.getAccount('bank'))
+		TriggerClientEvent('orp_banking:notify', source, 'You have successfully deposited $'.. amount, 'success')
 	end
 end)
 
 RegisterNetEvent('orp_banking:withdraw', function(data)
-	local xPlayer = ESX.GetPlayerFromId(source)
-	local balance = xPlayer.getAccount('bank').money
+	local player = Player(source)
+	local balance = player.getAccount('bank')
 	local amount = tonumber(data?.amount)
 
 	if not amount or amount <= 0 or amount > balance then
-		TriggerClientEvent('orp_banking:notify', xPlayer.source, 'Invalid amount', 'error')
+		TriggerClientEvent('orp_banking:notify', source, 'Invalid amount', 'error')
 	else
-		xPlayer.removeAccountMoney('bank', amount)
-		xPlayer.addMoney(amount)
-		TriggerClientEvent('orp_banking:update', xPlayer.source, balance - amount)
-		TriggerClientEvent('orp_banking:notify', xPlayer.source, 'You have successfully withdrawn $'.. amount, 'success')
+		player.removeAccount('bank', amount)
+		inventory:AddItem(source, 'money', amount)
+		TriggerClientEvent('orp_banking:update', source, balance - amount)
+		TriggerClientEvent('orp_banking:notify', source, 'You have successfully withdrawn $'.. amount, 'success')
 	end
 end)
 
 RegisterNetEvent('orp_banking:transfer', function(data)
-	local xPlayer = ESX.GetPlayerFromId(source)
-	local xTarget = ESX.GetPlayerFromId(data?.target)
 	local amount = tonumber(data?.amount)
 
-	if not amount or amount <= 0 then
-		TriggerClientEvent('orp_banking:notify', xPlayer.source, 'Invalid amount', 'error')
-	elseif xTarget == nil or xTarget == -1 then
-		TriggerClientEvent('orp_banking:notify', xPlayer.source, 'Recipient not found', 'error')
-	elseif xPlayer.source == xTarget.source then
-		TriggerClientEvent('orp_banking:notify', xPlayer.source, 'You cannot transfer money to yourself', 'error')
+	if type(data?.target) ~= 'number' then
+		TriggerClientEvent('orp_banking:notify', source, 'Recipient not found', 'error')
+	elseif data?.target == source then
+		TriggerClientEvent('orp_banking:notify', source, 'You cannot transfer money to yourself', 'error')
+	elseif not amount or amount <= 0 then
+		TriggerClientEvent('orp_banking:notify', source, 'Invalid amount', 'error')
 	else
-		local balance = xPlayer.getAccount('bank').money
+		local player = Player(source)
+		local target = Player(data.target)
+		local balance = player.getAccount('bank')
+
 		if balance <= 0 or balance < amount or amount <= 0 then
-			TriggerClientEvent('orp_banking:notify', xPlayer.source, 'You don\'t have enough money for this transfer', 'error')
+			TriggerClientEvent('orp_banking:notify', source, 'You don\'t have enough money for this transfer', 'error')
 		else
-			xPlayer.removeAccountMoney('bank', amount)
-			TriggerClientEvent('orp_banking:update', xPlayer.source, balance - amount)
-			TriggerClientEvent('orp_banking:notify', xPlayer.source, 'You have successfully transferred $'.. amount, 'success')
+			player.removeAccount('bank', amount)
+			TriggerClientEvent('orp_banking:update', source, balance - amount)
+			TriggerClientEvent('orp_banking:notify', source, 'You have successfully transferred $'.. amount, 'success')
 
-			xTarget.addAccountMoney('bank', amount)
-			TriggerClientEvent('orp_banking:update', xTarget.source, xTarget.getAccount('bank').money)
-			TriggerClientEvent('orp_banking:notify', xTarget.source, 'You just received $'.. amount ..' via bank transfer', 'success')
+			target.addAccount('bank', amount)
+			TriggerClientEvent('orp_banking:update', source, target.getAccount('bank'))
+			TriggerClientEvent('orp_banking:notify', source, 'You just received $'.. amount ..' via bank transfer', 'success')
 		end
 	end
 end)