click-odoo-update: new CLI option to control files that are part of the modules hash

[yassinelachgar]

As far as I know, changes in .py files does not imply a module update for the changes to work. Would it not be optimal to detect changes only in XML files ?

The problem here is that a simple change in .py file triggers the module updates which takes additional time when running the server.

[sbidoul]

Yes it is necessary because python files contain model and field definitions that need a database upgrade when changed.

[yassinelachgar]

Oh right, I totally missed that. But it would be nice if there was an option --ignore-py in case of minor changes that dont contain models or fields definition, don't you think ?

[sbidoul]

There is already a system parameter in the database to control which files are part of the hash:

click-odoo-contrib/click_odoo_contrib/update.py

Lines 26 to 27 in d7f8c32

	PARAM_EXCLUDE_PATTERNS = "module_auto_update.exclude_patterns"
	DEFAULT_EXCLUDE_PATTERNS = "*.pyc,*.pyo,i18n/*.pot,i18n_extra/*.pot,static/*"

It could be interesting to control it with a CLI option too -- although it is a potential footgun :).

[yassinelachgar]

Merci stéphane 👍

[yassinelachgar]

If it's okay I'll work on a PR for this feature.

[sbidoul]

If it's okay I'll work on a PR for this feature.

@yassinelachgar that is very welcome, thank you. I might be interesting to discuss the CLI option first (i.e. update the documentation in the README before coding). Also, when it comes to it, don't forget tests.