events to subscribe for enterprise runners

[swathida-byte]

this is what I currently have in my scaler.yaml

apiVersion: actions.summerwind.dev/v1alpha1
metadata:
  name: re-centos7-scaler
kind: HorizontalRunnerAutoscaler
spec:
  scaleTargetRef:
    name: re-centos7-deployment
  minReplicas: 1
  maxReplicas: 25
  scaleUpTriggers:
    - githubEvent:
        pullRequest:
          types: ["reopened","opened","edited","synchronize"]
      amount: 1
      duration: "120s"

what do I replace with pull-request event because at enterprise level there is no event type pull-request

[toast-gear]

we have deprecated all webhook events other than workflowJob, support for the other events will be removed in future versions of ARC as the Workflow Job event is the only event type you need, it was purpose built for runner scaling solutions like ARC. You need to migrate your webhooks and HRAs to the Workflow Job event.

[swathida-byte]

I'm getting
error: error validating "single.yaml": error validating data: ValidationError(HorizontalRunnerAutoscaler.spec.scaleUpTriggers[0].githubEvent): unknown field "workflowJob" in dev.summerwind.actions.v1alpha1.HorizontalRunnerAutoscaler.spec.scaleUpTriggers.githubEvent; if you choose to ignore these errors, turn validation off with --validate=false

I'm using v.22.0

[toast-gear]

Your CRDs are out of date, I assume you manage ARC via Helm https://github.com/actions-runner-controller/actions-runner-controller/blob/master/charts/actions-runner-controller/docs/UPGRADING.md

[swathida-byte]

I have changed my yaml file to

apiVersion: actions.summerwind.dev/v1alpha1
metadata:
  name: re-centos7-scaler
kind: HorizontalRunnerAutoscaler
spec:
  scaleTargetRef:
    name: re-centos7-deployment
  minReplicas: 1
  maxReplicas: 25
  scaleUpTriggers:
    - githubEvent:
        workflowJob: {}
      duration: "120s"

I'm still getting unknown field "workflowJob"

[toast-gear]

You almost certainly don't want a duration that short, please read the webhook documentation again to understand what it does https://github.com/actions-runner-controller/actions-runner-controller#webhook-driven-scaling.

Did you read https://github.com/actions-runner-controller/actions-runner-controller/blob/master/charts/actions-runner-controller/docs/UPGRADING.md?

[swathida-byte]

Apparently, I found the bug https://github.com/actions-runner-controller/actions-runner-controller/blob/v0.22.0/charts/actions-runner-controller/crds/actions.summerwind.dev_horizontalrunnerautoscalers.yaml#L165 there no workflow job GitHub event

In v0.22.0 version please update crd code

[toast-gear]

I missed you're on v0.22.0, that's an extremely old version, you need to upgrade to latest