Fail-fast on children of negated glob directory matches like Git does #657
Description
Describe the enhancement
The default globbing technique investigates all paths, even ones that have already been invalidated by negated matchers:
toolkit/packages/glob/src/internal-pattern-helper.ts
Lines 59 to 81 in 1cc56db
This differs from Git's globbing technique used in the
.gitignore files here:
It is not possible to re-include a file if a parent directory of that file is excluded. Git doesn’t list excluded directories for performance reasons, so any patterns on contained files have no effect, no matter where they are defined.
This is unintuitive because many developers are already familiar with Git's globbing style and can inadvertently introduce performance problems by including arbitrary folders and trying (and failing) to exclude certain large directories.
Additional information
limjh16/jekyll-action-ts#3 (comment) describes a significant performance penalty from searching everywhere for a certain file name.