Merge pull request #126 from activeadmin-plugins/constantize_vars

constantize unchaged variables

Author: Fivell

Gemfile

@@ -23,8 +23,8 @@ group :test do
   gem 'pry'
   gem 'database_cleaner'
   gem 'capybara'
-  gem 'selenium-webdriver'
   gem 'poltergeist'
+  gem 'selenium-webdriver', '< 3.0', platforms: :ruby_19
   gem 'json', '< 2.0', platforms: :ruby_19 # Json 2.0 requires Ruby >= 2.0
   gem 'mime-types', '< 3.0.0', platforms: [:ruby_19, :ruby_20]
   gem 'tins', '< 1.3.4', platforms: :ruby_19

lib/active_admin_import/model.rb

@@ -2,13 +2,28 @@
 # frozen_string_literal: true
 
 require 'rchardet'
+require 'zip'
 
 module ActiveAdminImport
   class Model
     include ActiveModel::Model
     include ActiveModel::Validations
     include ActiveModel::Validations::Callbacks
 
+    module CONST
+      ZIP_TYPE = 'application/zip'.freeze
+      TMP_FILE = 'active-admin-import-unzipped'.freeze
+      CSV_TYPES = %w(
+        text/csv
+        text/x-csv
+        text/x-comma-separated-values
+        text/comma-separated-values
+        application/csv
+        application/vnd.ms-excel
+        application/vnd.msexcel
+      ).freeze
+    end
+
     validates :file, presence: {
       message: ->(*_) { I18n.t('active_admin_import.no_file_error') }
     }, unless: ->(me) { me.new_record? }
@@ -66,7 +81,7 @@ def persisted?
     end
 
     def archive?
-      file_type == 'application/zip'
+      file_type == CONST::ZIP_TYPE
     end
 
     alias to_hash attributes
@@ -90,24 +105,15 @@ def encode_file
 
     def unzip_file
       Zip::File.open(file_path) do |zip_file|
-        self.file = Tempfile.new('active-admin-import-unzipped')
+        self.file = Tempfile.new(CONST::TMP_FILE)
         data = zip_file.entries.select(&:file?).first.get_input_stream.read
         file << data
         file.close
       end
     end
 
     def csv_allowed_types
-      [
-        'text/csv',
-        'text/x-csv',
-        'text/x-comma-separated-values',
-        'text/comma-separated-values',
-        'application/csv',
-        'application/vnd.ms-excel',
-        'application/vnd.msexcel'
-
-      ]
+      CONST::CSV_TYPES
     end
 
     def correct_content_type