specs for failed imports, validations

Author: Fivell

lib/active_admin_import/dsl.rb

@@ -88,7 +88,7 @@ def active_admin_import(options = {}, &block)
           else
             instance_exec result, options, &DEFAULT_RESULT_PROC
           end
-        rescue ActiveRecord::Import::MissingColumnError, NoMethodError => e
+        rescue ActiveRecord::Import::MissingColumnError, NoMethodError, ActiveRecord::StatementInvalid => e
           flash[:error] = I18n.t('active_admin_import.file_error', message: e.message)
         end
         redirect_to options[:back]

spec/fixtures/files/author_invalid.csv

@@ -0,0 +1,2 @@
+Name,Last name,Birthday
+,Doe,1986-05-01

spec/fixtures/files/authors_invalid_db.csv

@@ -0,0 +1,3 @@
+Name,Last name,Birthday
+John,Doe,1986-05-01
+John,Doe,1986-05-01

spec/import_spec.rb

@@ -56,7 +56,6 @@ def upload_file!(name, ext='csv')
     end
 
 
-
   end
 
   context "with valid options" do
@@ -149,9 +148,39 @@ def upload_file!(name, ext='csv')
             expect(Author.count).to eq(0)
           end
         end
+      end
 
+      context "with invalid data insert" do
+        it "should render error" do
+          upload_file!(:authors_invalid_db)
+          expect(page).to have_content "Error:"
+          expect(Author.count).to eq(0)
+        end
       end
 
+      context "with invalid records" do
+
+        context "with validation" do
+          it "should render error" do
+            upload_file!(:author_invalid)
+            expect(page).to have_content "Failed to import 1 author"
+            expect(Author.count).to eq(0)
+          end
+        end
+
+
+        context "without validation" do
+          let(:options) { {validate: false} }
+          it "should render error" do
+            upload_file!(:author_invalid)
+            expect(page).to have_content "Successfully imported 1 author"
+            expect(Author.count).to eq(1)
+          end
+
+        end
+
+
+      end
 
       context "when zipped" do
         context "when allowed" do

spec/support/rails_template.rb

@@ -1,8 +1,9 @@
 # Rails template to build the sample app for specs
 
-generate :model, 'author name:string last_name:string birthday:date'
-
+generate :model, 'author name:string{10}:uniq last_name:string birthday:date'
 
+#Add validation
+inject_into_file "app/models/author.rb", "  validates_presence_of :name\n", after: "Base\n"
 
 # Configure default_url_options in test environment
 inject_into_file "config/environments/test.rb", "  config.action_mailer.default_url_options = { :host => 'example.com' }\n", after: "config.cache_classes = true\n"