Merge pull request #28 from Fivell/win1251

win1251 specs

Author: Fivell

lib/active_admin_import/model.rb

@@ -132,9 +132,16 @@ def define_methods_for(attr_name)
     end
 
     def encode(data)
-      data.encode(force_encoding, "binary",
-                  invalid: :replace, undef: :replace,  replace: "").
-          sub("\xEF\xBB\xBF", "")
+      data = data.force_encoding("UTF-8")
+      unless data.valid_encoding?
+        data = data.encode(force_encoding,
+                           invalid: :replace, undef: :replace, replace: "")
+      end
+      begin
+        data.sub("\xEF\xBB\xBF", "")   # bom
+      rescue ArgumentError => _
+        data
+      end
     end
 
     class <<self

spec/fixtures/files/authors_win1251_win_endline.csv

@@ -0,0 +1,3 @@
+Name,Last name,Birthday
+Алексей,Панкратов,1986-05-01
+Jane,Roe,1988-11-16

spec/import_spec.rb

@@ -112,6 +112,24 @@ def upload_file!(name, ext='csv')
         end
       end
 
+      context "Win1251" do
+
+        before do
+          upload_file!(:authors_win1251_win_endline)
+        end
+
+        it "should import file with many records" do
+          expect(page).to have_content "Successfully imported 2 authors"
+          expect(Author.count).to eq(2)
+          Author.all.each do |author|
+            expect(author).to be_valid
+            expect(author.name).to be_present
+            expect(author.last_name).to be_present
+          end
+        end
+
+      end
+
       context "BOM" do
 
         it "should import file with many records" do