Merge pull request #133 from activeadmin-plugins/feature-tab-separator

support for tsv files

Author: Fivell

.travis.yml

@@ -4,20 +4,14 @@ env:
     - RAILS=4.2.6
     - RAILS=5.0.0
 rvm:
-  - 1.9.3
-  - 2.0.0
   - 2.1.9
   - 2.2.5
   - 2.3.1
 matrix:
   exclude:
-    - rvm: 1.9.3
-      env: RAILS=5.0.0
-    - rvm: 2.0.0
-      env: RAILS=5.0.0
     - rvm: 2.1.9
-      env: RAILS=5.0.0
+      env: RAILS=5.0.0 # Rails 5.0 requires Ruby 2.2.2 or newer
 before_install:
-  - gem install bundler -v '= 1.9.3'
-  - gem update --system
-  - gem --version
+  - gem update --system # use the very latest Rubygems
+  - rvm @global do gem uninstall bundler -a -x
+  - rvm @global do gem install bundler -v 1.14.6 # latest version known to work

lib/active_admin_import/dsl.rb

@@ -94,6 +94,7 @@ def active_admin_import(options = {}, &block)
           end
         rescue ActiveRecord::Import::MissingColumnError, NoMethodError, ActiveRecord::StatementInvalid, CSV::MalformedCSVError => e
           Rails.logger.error(I18n.t('active_admin_import.file_error', message: e.message))
+          Rails.logger.error(e.backtrace.join("\n"))
           flash[:error] = I18n.t('active_admin_import.file_error', message: e.message[0..200])
         end
         redirect_to options[:back]

lib/active_admin_import/importer.rb

@@ -119,7 +119,7 @@ def detect_csv_options
                        model.csv_options
                      else
                        options[:csv_options] || {}
-                     end.reject { |_, value| value.blank? }
+                     end.reject { |_, value| value.nil? || value == "" }
     end
   end
 end

lib/active_admin_import/model.rb

@@ -21,6 +21,10 @@ module CONST
         application/csv
         application/vnd.ms-excel
         application/vnd.msexcel
+        text/tsv
+        text/x-tsv
+        text/tab-separated-values
+        text/x-tab-separated-values
       ).freeze
     end
 

spec/fixtures/files/authors_with_tabs.tsv

@@ -0,0 +1,3 @@
+Name	Last name	Birthday
+John	Doe	1986-05-01
+Jane	Roe	1988-11-16

spec/import_spec.rb

@@ -397,6 +397,19 @@ def upload_file!(name, ext = 'csv')
           expect(Author.count).to eq(2)
         end
       end
+
+      context 'with tab separator' do
+        let(:options) do
+          attributes = { csv_options: { col_sep: "\t" } }
+          { template_object: ActiveAdminImport::Model.new(attributes) }
+        end
+
+        it 'should import file' do
+          upload_file!(:authors_with_tabs, 'tsv')
+          expect(page).to have_content 'Successfully imported 2 authors'
+          expect(Author.count).to eq(2)
+        end
+      end
     end
 
     context 'with callback procs options' do