Merge pull request #16 from workgena/undefined_build_sidebar

Fix compatibility with ActiveAdmin 1.4-pre

Author: Fivell

.travis.yml

@@ -0,0 +1,19 @@
+sudo: required
+language: ruby
+addons:
+  chrome: stable
+
+before_install: gem install bundler -v 1.17.1
+
+script: bundle exec rspec
+
+env:
+  matrix:
+    - RAILS=5.1.6 AA=1.1.0
+    - RAILS=5.1.6 AA=1.2.1
+    - RAILS=5.2.1 AA=1.3.1
+    - RAILS=5.2.1 AA=1-4-stable
+
+rvm:
+  - 2.3
+  - 2.5

Gemfile

@@ -4,16 +4,18 @@ source 'https://rubygems.org'
 gemspec
 
 group :test do
-  gem 'sprockets-rails', '3.2.0'
-  gem 'rails', '5.1.1'
-  gem 'turbolinks'
+  gem 'rails', "#{ENV['RAILS'] || '5.2.1'}"
+  if ENV['AA'] == '1-4-stable'
+    gem 'activeadmin', git: 'https://github.com/activeadmin/activeadmin.git', branch: '1-4-stable'
+  else
+    gem 'activeadmin', "#{ENV['AA'] || '1.3.1'}"
+  end
+
   gem 'rspec-rails'
-  gem 'activeadmin', '1.0.0'
-  gem 'sass-rails'
   gem 'sqlite3'
-  gem 'launchy'
   gem 'database_cleaner'
   gem 'capybara'
   gem 'selenium-webdriver'
-  gem 'poltergeist'
+  gem 'chromedriver-helper'
+  gem 'byebug'
 end

lib/active_admin_sidebar.rb

@@ -7,6 +7,7 @@ module ActiveAdminSidebar
   module Rails
     class Engine < ::Rails::Engine
       config.after_initialize do
+        ActiveAdmin::Views::Pages::Base.prepend ActiveAdminSidebar::ActiveAdminViewsPagesBase
         ActiveAdmin::BaseController.send :include, ActiveAdminSidebar::Positions
       end
     end

lib/active_admin_sidebar/activeadmin_views_pages_base.rb

@@ -1,4 +1,4 @@
-class ActiveAdmin::Views::Pages::Base < Arbre::HTML::Document
+module ActiveAdminSidebar::ActiveAdminViewsPagesBase
 
   def build_page_content
     build_flash_messages
@@ -9,6 +9,14 @@ def build_page_content
     end
   end
 
+  def build_sidebar
+    if defined?(super)
+      super
+    else
+      sidebar sidebar_sections_for_action, id: 'sidebar'
+    end
+  end
+
   def left_sidebar?
     assigns[:sidebar_options].try!(:[], :position) == :left
   end

spec/spec_helper.rb

@@ -27,11 +27,12 @@
 ActiveAdmin.application.current_user_method = false
 
 require 'rspec/rails'
-require 'support/admin'
 require 'capybara/rails'
 require 'capybara/rspec'
-require 'capybara/poltergeist'
+require 'selenium-webdriver'
 
+require 'support/admin'
+require 'support/capybara'
 
 RSpec.configure do |config|
   config.use_transactional_fixtures = false
@@ -49,20 +50,3 @@
   end
 
 end
-
-# RSpec.configure do |config|
-#   config.before(:each, js: true) do
-#     page.driver.browser.manage.window.maximize  if page.driver.browser.respond_to?(:manage)
-#   end
-# end
-# Capybara.javascript_driver = :selenium
-
-Capybara.register_driver :poltergeist do |app|
-  Capybara::Poltergeist::Driver.new(app, {
-    js_errors: true,
-    timeout: 80,
-    debug: true,
-    :phantomjs_options => ['--debug=no', '--load-images=no']
-  })
-end
-Capybara.javascript_driver = :poltergeist

spec/support/capybara.rb

@@ -0,0 +1,13 @@
+Capybara.configure do |config|
+  config.match = :prefer_exact
+end
+
+Capybara.register_driver :selenium_chrome do |app|
+  options = Selenium::WebDriver::Chrome::Options.new(
+    args: %w[headless disable-gpu no-sandbox]
+  )
+  Capybara::Selenium::Driver.new(app, browser: :chrome, options: options)
+end
+
+Capybara.server = :webrick
+Capybara.javascript_driver = :selenium_chrome

tasks/test.rake

@@ -2,5 +2,13 @@ desc "Creates a test rails app for the specs to run against"
 task :setup do
   require 'rails/version'
   system("mkdir spec/rails") unless File.exists?("spec/rails")
-  system "bundle exec rails new spec/rails/rails-#{Rails::VERSION::STRING} -m spec/support/rails_template.rb --skip-spring"
+
+  rails_new_opts = %w(
+    --skip-turbolinks
+    --skip-spring
+    --skip-bootsnap
+    -m
+    spec/support/rails_template.rb
+  )
+  system "bundle exec rails new spec/rails/rails-#{Rails::VERSION::STRING} #{rails_new_opts.join(' ')}"
 end