Skip to content

Commit eddb9ce

Browse files
committed
Remove frozen string literals from arb templates
It does not have effect there and outputs a warning when running tests with `RUBYOPTS='-w' rake` ``` warning: 'frozen_string_literal' is ignored after any tokens ``` Behavior tested in `empty.arb` template ``` # frozen_string_literal: true hello = 'hello' hello.concat ' world' ``` Expected: fail Actual: pass Close #649
1 parent eafd5fb commit eddb9ce

9 files changed

+1
-8
lines changed

.rubocop.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -584,6 +584,7 @@ Style/FrozenStringLiteralComment:
584584
Enabled: true
585585
Exclude:
586586
- bin/console
587+
- '**/*.arb'
587588

588589
Style/HashSyntax:
589590
Enabled: true
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
# frozen_string_literal: true
21
para "Hello from a partial"
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
# frozen_string_literal: true
21
para "Partial: #{my_instance_var}"
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# frozen_string_literal: true
21
h1 "Before Partial"
32
render "arbre/partial_with_assignment"
43
h2 "After Partial"
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
# frozen_string_literal: true
21
h1 my_instance_var
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# frozen_string_literal: true
21
h1 "Before Partial"
32
render "erb/partial"
43
h2 "After Partial"
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# frozen_string_literal: true
21
h1 "Before Partial"
32
render "arbre/partial"
43
h2 "After Partial"

spec/rails/templates/arbre/page_with_render_with_block.arb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# frozen_string_literal: true
21
render_in_object = Class.new do
32
def render_in(_, &block)
43
block.call

spec/rails/templates/arbre/simple_page.arb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# frozen_string_literal: true
21
html do
32
head do
43
end

0 commit comments

Comments
 (0)