Skip to content

Commit eff36a1

Browse files
committed
fix rubocop offense, do not define ol_attrs again
1 parent 53ea12d commit eff36a1

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

app/views/active_scaffold_overrides/_field_search_columns.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<% end %>
1111
<% end %>
1212
<% else -%>
13-
<%= as_element :field_search_fields_container, **ol_attrs.merge(class: 'form') do %>
13+
<%= as_element :field_search_fields_container, class: 'form', **ol_attrs do %>
1414
<% visibles, hiddens = visibles_and_hiddens(active_scaffold_config.field_search, columns) %>
1515
<% visibles.each do |column| -%>
1616
<%= render_field_search_column(column, @record) %>

app/views/active_scaffold_overrides/_form.html.erb

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,8 @@
1717
tabbed_by ||= nil
1818
tab_id ||= nil
1919
show_unauthorized_columns = active_scaffold_config.send(form_action).show_unauthorized_columns if active_scaffold_config.actions.include? form_action
20-
ol_attrs = {class: 'form'}
21-
ol_attrs[:id] = subsection_id unless subsection_id.nil?
22-
ol_attrs[:style] = 'display: none;' if columns.collapsed
2320
%>
24-
<%= as_element :fields_container, **ol_attrs do %>
21+
<%= as_element :fields_container, class: 'form', **ol_attrs do %>
2522
<% columns.each_column(for: @record, crud_type: (:read if show_unauthorized_columns)) do |column| %>
2623
<% column_css_class = column.css_class unless column.css_class.is_a?(Proc) %>
2724
<% renders_as = column_renders_as(column) %>

0 commit comments

Comments
 (0)