Skip to content

Commit f895630

Browse files
committed
Merge branch 'master' into framework-ui
# Conflicts: # .github/workflows/ci.yml
2 parents 13b315a + 3519b02 commit f895630

File tree

4 files changed

+29
-6
lines changed

4 files changed

+29
-6
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191
strategy:
9292
fail-fast: false
9393
matrix:
94-
ruby: [ "3.4", "3.3", "3.2", "jruby-10.0" ]
94+
ruby: [ "4.0", "3.4", "3.3", "3.2", "jruby-10.0" ]
9595
rails: [ "8.1", "8.0", "7.2" ]
9696
exclude:
9797
- ruby: 'jruby-10.0'
@@ -100,8 +100,8 @@ jobs:
100100
- ruby: '3.4'
101101
rails: '7.2'
102102
coverage: true
103-
# - rails: '8.1'
104-
# allow_failure: true
103+
- ruby: '4.0'
104+
allow_failure: true
105105
timeout-minutes: 60
106106
env:
107107
JRUBY_OPTS: "--debug"

CHANGELOG.rdoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
- Fix replacing tinymce fields with update_columns
2+
13
= 4.2.0
24
- Integrate LogicalQueryParser, supporting full logical search, or simplified searches with 'all keywords' and 'any keyword' operators.
35
- Display unauthorized column in form as show action, so show_ui or show override is used if exists.

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@ ActiveScaffold provides a quick and powerful user interfaces for CRUD (create, r
1313
Branch Details
1414
--------------
1515
master supports rails >= 7.2.x and ruby >= 3.2.0
16-
4-1-stable supports rails >= 7.0.x and <= 7.2.x, and ruby >= 3.1.0
16+
4-2-stable supports rails >= 7.2.x and ruby >= 3.2.0
1717

1818
These versions are not supported anymore:
19-
4-0-stable supports rails >= 6.1.x and <= 7.2.x, and ruby >= 2.5.0
20-
3-7-stable supports rails >= 5.2.x and <= 7.1.x, and ruby >= 2.5.0
19+
4-1-stable supports rails >= 7.0.x and <= 7.2.x, and ruby >= 3.1.0
20+
4-0-stable supports rails >= 6.1.x and <= 7.2.x, and ruby >= 2.5.0
21+
3-7-stable supports rails >= 5.2.x and <= 7.1.x, and ruby >= 2.5.0
2122
3-6-stable supports rails >= 4.2.x and <= 6.1.x, and ruby >= 2.3.0
2223
3-5-stable supports rails >= 4.0.x and <= 5.1.x, and ruby >= 2.0.0
2324
3-4-stable supports rails >= 3.2.x and <= 4.2.x, and ruby >= 1.9.3

app/assets/javascripts/jquery/tiny_mce_bridge.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,26 @@
77
action_link_close.apply(this);
88
};
99

10+
ActiveScaffold.remove_tinymce = function(element) {
11+
if (typeof(element) == 'string') element = '#' + element;
12+
element = jQuery(element);
13+
element.find('textarea.mceEditor').each(function(index, elem) {
14+
tinymce.remove('#' + elem.id);
15+
});
16+
};
17+
18+
var as_replace = ActiveScaffold.replace,
19+
as_replace_html = ActiveScaffold.replace_html;
20+
21+
ActiveScaffold.replace = function(element) {
22+
this.remove_tinymce(element);
23+
return as_replace.apply(this, arguments);
24+
};
25+
ActiveScaffold.replace_html = function(element) {
26+
this.remove_tinymce(element);
27+
return as_replace_html.apply(this, arguments);
28+
};
29+
1030
function loadTinyMCE() {
1131
var global_settings = ActiveScaffold.config.tiny_mce_settings || {};
1232
var local_settings = jQuery(this).data('tinymce');

0 commit comments

Comments
 (0)