Sprockets::FileNotFound couldn't find file 'jquery-ui/core' with type 'application/javascript'

[hugoarpin]

jQuery UI 1.14 removed the deprecated ui/core.js file: https://jqueryui.com/changelog/1.14.0/#ui-core
Gem jquery-ui-rails v8.0.0 upgraded jQuery UI to v1.14.1: https://github.com/jquery-ui-rails/jquery-ui-rails/releases/tag/v8.0.0
Line causing issue:

active_scaffold/app/assets/javascripts/active_scaffold.js.erb

Line 9 in 724574f

require_asset "#{jquery_ui_prefix}core"

Thanks!

[scambra]

This is fixed in AS 4.1.0

[hugoarpin]

Thanks! 👍

PS: The new scss directives "@use" on top of active_scaffold.scss ('active_scaffold_layout', etc.) are not including the specified files in my project. If I replace them with the old "@import" syntax (by altering the code in the gem), then it works! I have the gem dartsass-sprockets (3.2.1) installed. Sorry, out of topic for this issue, but any quick idea of how I can fix it? Thanks!

[scambra]

I have checked a project where I'm using . One of them has @use defining variables in a theme.scss file:

@use 'active_scaffold' with (
  $nested_bg: #e8f1ea,
  $form_title_color: #172751,
  $second_nested_bg: #F4F1EA,
);

And theme.scss is required in application.scss:
*= require theme

In another project, @use is in a .scss file too, and the file is required in a .css.erb file. Are you using @use in a .scss file? It probably won't work if the extension is .css

[hugoarpin]

It is included via a Sprockets directive (*= require active_scaffold) above a top-level .css.erb file (backend.css.erb), which also requires all the other dependencies for the layout.

If I try switching the main file to scss (or create a new file: active_scaffold_import.scss) and require active_scaffold via a "@use 'active_scaffold';" scss directive, it does not work either (only active_scaffold.scss is loaded, but not its "@use" dependencies).

PS: I know Sprockets is now deprecated, but I am not very convinced by Propshaft. Do you know if active_scaffold does (or will) support jsbundling-rails & cssbundling-rails as an alternative?

Thanks, I very much appreciate your support!

[scambra]

I haven't tested with cssbundling-rails, I just used dartsass-sprockets, with uses sprockets, and it worked to me when using @use in a scss file, which is required from application (tested with both scss and css.erb), active_scaffold_layout, active_scaffold_images, active_scaffold_jquery_ui and active_scaffold_extensions were loaded.

For example, I can see the rules from active_scaffold_layout.css in the generated application.css, although I don't see active_scaffold.source.scss or active_scaffold_layout.source.css in the web inspector

[hugoarpin]

Ok, there must a be a quirk in my setup then! I have other work to merge before upgrading active_scaffold, but when I'm ready to do so, I will let you know if I find anything worth mentioning in my future investigation. Thanks for checking, regards!

[planetmcd]

I just tried a test with cssbundling and propshaft (no sprockets in the Gemfile of the app). From what I can tell, there is a failure because dartsass-rails is expected for cssbundling, but dartsass-sprockets conflicts so build doesn't work.

[hugoarpin]

I did not think about that, thanks for the feedback @planetmcd! I have not yet had the time to begin migrating to cssbundling/propshaft, but I don't think this conflict can be resolved outside of the active_scaffold gem itself...

[planetmcd]

@hugoarpin That is my conclusion. My last comment was a bit vague. dartsass-sprockets is required by activeadmin, so it gets installed. Looking at the results here, https://github.com/search?q=repo%3Aactivescaffold%2Factive_scaffold%20dart&type=code.

It might not really be needed, but I don't have time right now to figure it out.

[scambra]

In that case dartsass-sprockets could be removed from gemspec and don't require It in AS 4.2, and provide instructions so users add it to their Gemfile if they are not using cssbundling, or cssbundling may be detected to avoid requiring dartsass-sprockets in that case.

[hugoarpin]

Hello @scambra, both options seem good to me! Of course, auto-detection would be the best option for the gem, but I wonder if it can be done easily and reliably? Maybe!

Sorry, I still don't have time to look into it, but I will let you know if I find some useful insights when I will finally have the time to look into propshaft. Thanks for your support!

[clyfe]

@scambra In the future do we want to support both Sprockets and Propshaft?
If the plan is to remove Sprockets altogether, it would look kind of like this.

[scambra]

@clyfe As I think rails doesn't force to use one gem, I think some users would like to keep using sprockets for old apps, with importmaps, and others may want to use propshaft. Dartsass-sprockets could be removed as dependency, so if user wants to use it, will add to Gemfile and require is not needed.

I could do something like you did in your fork, but having some methods to return the JS and CSS assests to load, so the old css.erb and js.erb files can call them, and they can be used in active_scaffold_stylesheets and active_scaffold_javascripts.
How is active_scaffold_assets suppose to be used? Adding it in the layout? How is active_scaffold.scss loaded? I see active_scaffold_javascripts includes all files that were included by active_scaffold.js.erb, but active_scaffold_stylesheets only includes the code from active_scaffold_extensions.css.erb and active_scaffold_query_ui.css.erb.

Another possible change would be replacing SASS variables with CSS variables