compilation error when using actix-ws v0.3.0 with actix-web v4.12

[Baptistemontan]

When compiling actix-ws v0.3.0 with actix-web v4.12 this error is emitted:

error[E0277]: the trait bound `ProtocolError: Into<actix_web::Error>` is not satisfied
   --> actix-ws\src\stream.rs:140:49
    |
140 |                 return Poll::Ready(Some(Err(err.into())));
    |                                                 ^^^^ the trait `ResponseError` is not implemented for `ProtocolError`
    |
    = help: the following other types implement trait `ResponseError`:
              BlockingError
              Box<(dyn std::error::Error + 'static)>
              HttpError
              Infallible
              InvalidHeaderValue
              JsonPayloadError
              PathError
              PayloadError
            and 14 others
    = note: required for `actix_web::Error` to implement `std::convert::From<ProtocolError>`
    = note: required for `ProtocolError` to implement `Into<actix_web::Error>`

error[E0277]: `?` couldn't convert the error: `HandshakeError: ResponseError` is not satisfied
  --> actix-ws\src\lib.rs:75:45
   |
74 | ) -> Result<(HttpResponse, Session, MessageStream), actix_web::Error> {
   |      ---------------------------------------------------------------- required `HandshakeError: ResponseError` because of this
75 |     let mut response = handshake(req.head())?;
   |                        ---------------------^ the trait `ResponseError` is not implemented for `HandshakeError`
   |                        |
   |                        this has type `Result<_, HandshakeError>`
   |
   = note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
   = help: the following other types implement trait `ResponseError`:
             BlockingError
             Box<(dyn std::error::Error + 'static)>
             HttpError
             Infallible
             InvalidHeaderValue
             JsonPayloadError
             PathError
             PayloadError
           and 14 others
   = note: required for `actix_web::Error` to implement `std::convert::From<HandshakeError>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `actix-ws` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

[bottleofrum]

I had the same issue with actix-web v4.12.1. It worked with 4.8 though.

[Baptistemontan]

I had the same issue with actix-web v4.12.1. It worked with 4.8 though.

Apparently it happens when using default-features = false and not enabling back the "ws" feature, look if doing this solves your problem too

[bottleofrum]

Thanks, that helped.
But it still kind of sucks that you need to specify actix-web directly as your dependency with correct features enabled. I would expect that actix-ws does it so I still consider this issue as a minor bug.