chore: move deny lints to manifests

robjtede · robjtede · commit e0e4d1e66124 · 2024-07-07T03:54:00.000+01:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -51,3 +51,11 @@ awc = { path = "awc" }
 # actix-utils = { path = "../actix-net/actix-utils" }
 # actix-tls = { path = "../actix-net/actix-tls" }
 # actix-server = { path = "../actix-net/actix-server" }
+
+[workspace.lints.rust]
+rust_2018_idioms = { level = "deny" }
+future_incompatible = { level = "deny" }
+nonstandard_style = { level = "deny" }
+
+[workspace.lints.clippy]
+# clone_on_ref_ptr = { level = "deny" }
diff --git a/actix-files/Cargo.toml b/actix-files/Cargo.toml
@@ -54,3 +54,6 @@ actix-test = "0.1"
 actix-web = "4"
 env_logger = "0.11"
 tempfile = "3.2"
+
+[lints]
+workspace = true
diff --git a/actix-files/src/lib.rs b/actix-files/src/lib.rs
@@ -11,8 +11,7 @@
 //!     .service(Files::new("/static", ".").prefer_utf8(true));
 //! ```
 
-#![deny(rust_2018_idioms, nonstandard_style)]
-#![warn(future_incompatible, missing_docs, missing_debug_implementations)]
+#![warn(missing_docs, missing_debug_implementations)]
 #![doc(html_logo_url = "https://actix.rs/img/logo.png")]
 #![doc(html_favicon_url = "https://actix.rs/favicon.ico")]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
diff --git a/actix-http-test/Cargo.toml b/actix-http-test/Cargo.toml
@@ -59,3 +59,6 @@ tokio = { version = "1.24.2", features = ["sync"] }
 
 [dev-dependencies]
 actix-http = "3"
+
+[lints]
+workspace = true
diff --git a/actix-http-test/src/lib.rs b/actix-http-test/src/lib.rs
@@ -1,7 +1,5 @@
 //! Various helpers for Actix applications to use during testing.
 
-#![deny(rust_2018_idioms, nonstandard_style)]
-#![warn(future_incompatible)]
 #![doc(html_logo_url = "https://actix.rs/img/logo.png")]
 #![doc(html_favicon_url = "https://actix.rs/favicon.ico")]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
diff --git a/actix-http/Cargo.toml b/actix-http/Cargo.toml
@@ -167,6 +167,9 @@ tls-openssl = { package = "openssl", version = "0.10.55" }
 tls-rustls_023 = { package = "rustls", version = "0.23" }
 tokio = { version = "1.24.2", features = ["net", "rt", "macros"] }
 
+[lints]
+workspace = true
+
 [[example]]
 name = "ws"
 required-features = ["ws", "rustls-0_23"]
diff --git a/actix-http/src/h1/service.rs b/actix-http/src/h1/service.rs
@@ -541,6 +541,6 @@ where
 
     fn call(&self, (io, addr): (T, Option<net::SocketAddr>)) -> Self::Future {
         let conn_data = OnConnectData::from_io(&io, self.on_connect_ext.as_deref());
-        Dispatcher::new(io, self.flow.clone(), self.cfg.clone(), addr, conn_data)
+        Dispatcher::new(io, Rc::clone(&self.flow), self.cfg.clone(), addr, conn_data)
     }
 }
diff --git a/actix-http/src/h2/service.rs b/actix-http/src/h2/service.rs
@@ -434,7 +434,7 @@ where
 
         H2ServiceHandlerResponse {
             state: State::Handshake(
-                Some(self.flow.clone()),
+                Some(Rc::clone(&self.flow)),
                 Some(self.cfg.clone()),
                 addr,
                 on_connect_data,
diff --git a/actix-http/src/lib.rs b/actix-http/src/lib.rs
@@ -20,8 +20,6 @@
 //! [rustls]: https://crates.io/crates/rustls
 //! [trust-dns]: https://crates.io/crates/trust-dns
 
-#![deny(rust_2018_idioms, nonstandard_style)]
-#![warn(future_incompatible)]
 #![allow(
     clippy::type_complexity,
     clippy::too_many_arguments,
diff --git a/actix-http/src/message.rs b/actix-http/src/message.rs
@@ -66,7 +66,7 @@ impl<T: Head> ops::DerefMut for Message<T> {
 
 impl<T: Head> Drop for Message<T> {
     fn drop(&mut self) {
-        T::with_pool(|p| p.release(self.head.clone()))
+        T::with_pool(|p| p.release(Rc::clone(&self.head)))
     }
 }
 
diff --git a/actix-http/src/service.rs b/actix-http/src/service.rs
@@ -910,7 +910,7 @@ where
                     handshake: Some((
                         crate::h2::handshake_with_timeout(io, &self.cfg),
                         self.cfg.clone(),
-                        self.flow.clone(),
+                        Rc::clone(&self.flow),
                         conn_data,
                         peer_addr,
                     )),
@@ -926,7 +926,7 @@ where
                 state: State::H1 {
                     dispatcher: h1::Dispatcher::new(
                         io,
-                        self.flow.clone(),
+                        Rc::clone(&self.flow),
                         self.cfg.clone(),
                         peer_addr,
                         conn_data,
diff --git a/actix-http/src/test.rs b/actix-http/src/test.rs
@@ -159,8 +159,8 @@ impl TestBuffer {
     #[allow(dead_code)]
     pub(crate) fn clone(&self) -> Self {
         Self {
-            read_buf: self.read_buf.clone(),
-            write_buf: self.write_buf.clone(),
+            read_buf: Rc::clone(&self.read_buf),
+            write_buf: Rc::clone(&self.write_buf),
             err: self.err.clone(),
         }
     }
diff --git a/actix-multipart-derive/Cargo.toml b/actix-multipart-derive/Cargo.toml
@@ -29,3 +29,6 @@ actix-multipart = "0.7"
 actix-web = "4"
 rustversion = "1"
 trybuild = "1"
+
+[lints]
+workspace = true
diff --git a/actix-multipart-derive/src/lib.rs b/actix-multipart-derive/src/lib.rs
@@ -2,8 +2,6 @@
 //!
 //! See [`macro@MultipartForm`] for usage examples.
 
-#![deny(rust_2018_idioms, nonstandard_style)]
-#![warn(future_incompatible)]
 #![doc(html_logo_url = "https://actix.rs/img/logo.png")]
 #![doc(html_favicon_url = "https://actix.rs/favicon.ico")]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
diff --git a/actix-multipart/Cargo.toml b/actix-multipart/Cargo.toml
@@ -71,7 +71,5 @@ multer = "3"
 tokio = { version = "1.24.2", features = ["sync"] }
 tokio-stream = "0.1"
 
-[lints.rust]
-future_incompatible = { level = "deny" }
-rust_2018_idioms = { level = "deny" }
-nonstandard_style = { level = "deny" }
+[lints]
+workspace = true
diff --git a/actix-router/Cargo.toml b/actix-router/Cargo.toml
@@ -38,6 +38,9 @@ http = "0.2.7"
 serde = { version = "1", features = ["derive"] }
 percent-encoding = "2.1"
 
+[lints]
+workspace = true
+
 [[bench]]
 name = "router"
 harness = false
diff --git a/actix-router/src/lib.rs b/actix-router/src/lib.rs
@@ -1,7 +1,5 @@
 //! Resource path matching and router.
 
-#![deny(rust_2018_idioms, nonstandard_style)]
-#![warn(future_incompatible)]
 #![doc(html_logo_url = "https://actix.rs/img/logo.png")]
 #![doc(html_favicon_url = "https://actix.rs/favicon.ico")]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
diff --git a/actix-test/Cargo.toml b/actix-test/Cargo.toml
@@ -73,3 +73,6 @@ tls-rustls-0_21 = { package = "rustls", version = "0.21", optional = true }
 tls-rustls-0_22 = { package = "rustls", version = "0.22", optional = true }
 tls-rustls-0_23 = { package = "rustls", version = "0.23", default-features = false, optional = true }
 tokio = { version = "1.24.2", features = ["sync"] }
+
+[lints]
+workspace = true
diff --git a/actix-test/src/lib.rs b/actix-test/src/lib.rs
@@ -27,8 +27,6 @@
 //! }
 //! ```
 
-#![deny(rust_2018_idioms, nonstandard_style)]
-#![warn(future_incompatible)]
 #![doc(html_logo_url = "https://actix.rs/img/logo.png")]
 #![doc(html_favicon_url = "https://actix.rs/favicon.ico")]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
diff --git a/actix-web-actors/Cargo.toml b/actix-web-actors/Cargo.toml
@@ -41,3 +41,6 @@ actix-web = { version = "4", features = ["macros"] }
 env_logger = "0.11"
 futures-util = { version = "0.3.17", default-features = false, features = ["std"] }
 mime = "0.3"
+
+[lints]
+workspace = true
diff --git a/actix-web-actors/src/lib.rs b/actix-web-actors/src/lib.rs
@@ -55,8 +55,6 @@
 //! * [`HttpContext`]: This struct provides actor support for streaming HTTP responses.
 //!
 
-#![deny(rust_2018_idioms, nonstandard_style)]
-#![warn(future_incompatible)]
 #![doc(html_logo_url = "https://actix.rs/img/logo.png")]
 #![doc(html_favicon_url = "https://actix.rs/favicon.ico")]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
diff --git a/actix-web-codegen/Cargo.toml b/actix-web-codegen/Cargo.toml
@@ -35,3 +35,6 @@ actix-web = "4"
 futures-core = { version = "0.3.17", default-features = false, features = ["alloc"] }
 trybuild = "1"
 rustversion = "1"
+
+[lints]
+workspace = true
diff --git a/actix-web-codegen/src/lib.rs b/actix-web-codegen/src/lib.rs
@@ -73,8 +73,6 @@
 //! [DELETE]: macro@delete
 
 #![recursion_limit = "512"]
-#![deny(rust_2018_idioms, nonstandard_style)]
-#![warn(future_incompatible)]
 #![doc(html_logo_url = "https://actix.rs/img/logo.png")]
 #![doc(html_favicon_url = "https://actix.rs/favicon.ico")]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
diff --git a/actix-web-codegen/tests/routes.rs b/actix-web-codegen/tests/routes.rs
@@ -145,7 +145,7 @@ async fn custom_resource_name_test<'a>(req: HttpRequest) -> impl Responder {
 mod guard_module {
     use actix_web::{guard::GuardContext, http::header};
 
-    pub fn guard(ctx: &GuardContext) -> bool {
+    pub fn guard(ctx: &GuardContext<'_>) -> bool {
         ctx.header::<header::Accept>()
             .map(|h| h.preference() == "image/*")
             .unwrap_or(false)
diff --git a/actix-web-codegen/tests/scopes.rs b/actix-web-codegen/tests/scopes.rs
@@ -1,7 +1,7 @@
 use actix_web::{guard::GuardContext, http, http::header, web, App, HttpResponse, Responder};
 use actix_web_codegen::{delete, get, post, route, routes, scope};
 
-pub fn image_guard(ctx: &GuardContext) -> bool {
+pub fn image_guard(ctx: &GuardContext<'_>) -> bool {
     ctx.header::<header::Accept>()
         .map(|h| h.preference() == "image/*")
         .unwrap_or(false)
diff --git a/actix-web/Cargo.toml b/actix-web/Cargo.toml
@@ -188,6 +188,9 @@ tls-rustls = { package = "rustls", version = "0.23" }
 tokio = { version = "1.24.2", features = ["rt-multi-thread", "macros"] }
 zstd = "0.13"
 
+[lints]
+workspace = true
+
 [[test]]
 name = "test_server"
 required-features = ["compress-brotli", "compress-gzip", "compress-zstd", "cookies"]
diff --git a/actix-web/src/app.rs b/actix-web/src/app.rs
@@ -39,7 +39,7 @@ impl App<AppEntry> {
         let factory_ref = Rc::new(RefCell::new(None));
 
         App {
-            endpoint: AppEntry::new(factory_ref.clone()),
+            endpoint: AppEntry::new(Rc::clone(&factory_ref)),
             data_factories: Vec::new(),
             services: Vec::new(),
             default: None,
diff --git a/actix-web/src/app_service.rs b/actix-web/src/app_service.rs
@@ -71,7 +71,7 @@ where
         });
 
         // create App config to pass to child services
-        let mut config = AppService::new(config, default.clone());
+        let mut config = AppService::new(config, Rc::clone(&default));
 
         // register services
         mem::take(&mut *self.services.borrow_mut())
diff --git a/actix-web/src/config.rs b/actix-web/src/config.rs
@@ -68,7 +68,7 @@ impl AppService {
     pub(crate) fn clone_config(&self) -> Self {
         AppService {
             config: self.config.clone(),
-            default: self.default.clone(),
+            default: Rc::clone(&self.default),
             services: Vec::new(),
             root: false,
         }
@@ -81,7 +81,7 @@ impl AppService {
 
     /// Returns default handler factory.
     pub fn default_service(&self) -> Rc<BoxedHttpServiceFactory> {
-        self.default.clone()
+        Rc::clone(&self.default)
     }
 
     /// Register HTTP service.
diff --git a/actix-web/src/data.rs b/actix-web/src/data.rs
@@ -184,7 +184,7 @@ impl<T: ?Sized + 'static> FromRequest for Data<T> {
 
 impl<T: ?Sized + 'static> DataFactory for Data<T> {
     fn create(&self, extensions: &mut Extensions) -> bool {
-        extensions.insert(Data(self.0.clone()));
+        extensions.insert(Data(Arc::clone(&self.0)));
         true
     }
 }
diff --git a/actix-web/src/lib.rs b/actix-web/src/lib.rs
@@ -70,8 +70,6 @@
 //! - `rustls-0_23` - HTTPS support via `rustls` 0.23 crate, supports `HTTP/2`
 //! - `secure-cookies` - secure cookies support
 
-#![deny(rust_2018_idioms, nonstandard_style)]
-#![warn(future_incompatible)]
 #![doc(html_logo_url = "https://actix.rs/img/logo.png")]
 #![doc(html_favicon_url = "https://actix.rs/favicon.ico")]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
diff --git a/actix-web/src/middleware/default_headers.rs b/actix-web/src/middleware/default_headers.rs
@@ -141,7 +141,7 @@ where
     actix_service::forward_ready!(service);
 
     fn call(&self, req: ServiceRequest) -> Self::Future {
-        let inner = self.inner.clone();
+        let inner = Rc::clone(&self.inner);
         let fut = self.service.call(req);
 
         DefaultHeaderFuture {
diff --git a/actix-web/src/middleware/err_handlers.rs b/actix-web/src/middleware/err_handlers.rs
@@ -220,16 +220,20 @@ impl<B> ErrorHandlers<B> {
     /// [`.handler()`][ErrorHandlers::handler]) will fall back on this.
     ///
     /// Note that this will overwrite any default handlers previously set by calling
-    /// [`.default_handler_client()`][ErrorHandlers::default_handler_client] or
-    /// [`.default_handler_server()`][ErrorHandlers::default_handler_server], but not any set by
-    /// calling [`.handler()`][ErrorHandlers::handler].
+    /// [`default_handler_client()`] or [`.default_handler_server()`], but not any set by calling
+    /// [`.handler()`].
+    ///
+    /// [`default_handler_client()`]: ErrorHandlers::default_handler_client
+    /// [`.default_handler_server()`]: ErrorHandlers::default_handler_server
+    /// [`.handler()`]: ErrorHandlers::handler
     pub fn default_handler<F>(self, handler: F) -> Self
     where
         F: Fn(ServiceResponse<B>) -> Result<ErrorHandlerResponse<B>> + 'static,
     {
         let handler = Rc::new(handler);
+        let handler2 = Rc::clone(&handler);
         Self {
-            default_server: Some(handler.clone()),
+            default_server: Some(handler2),
             default_client: Some(handler),
             ..self
         }
@@ -288,7 +292,7 @@ where
     type Future = LocalBoxFuture<'static, Result<Self::Transform, Self::InitError>>;
 
     fn new_transform(&self, service: S) -> Self::Future {
-        let handlers = self.handlers.clone();
+        let handlers = Rc::clone(&self.handlers);
         let default_client = self.default_client.clone();
         let default_server = self.default_server.clone();
         Box::pin(async move {
@@ -323,7 +327,7 @@ where
     actix_service::forward_ready!(service);
 
     fn call(&self, req: ServiceRequest) -> Self::Future {
-        let handlers = self.handlers.clone();
+        let handlers = Rc::clone(&self.handlers);
         let default_client = self.default_client.clone();
         let default_server = self.default_server.clone();
         let fut = self.service.call(req);
diff --git a/actix-web/src/middleware/logger.rs b/actix-web/src/middleware/logger.rs
@@ -276,7 +276,7 @@ where
 
         ready(Ok(LoggerMiddleware {
             service,
-            inner: self.0.clone(),
+            inner: Rc::clone(&self.0),
         }))
     }
 }
diff --git a/actix-web/src/resource.rs b/actix-web/src/resource.rs
@@ -62,14 +62,14 @@ pub struct Resource<T = ResourceEndpoint> {
 impl Resource {
     /// Constructs new resource that matches a `path` pattern.
     pub fn new<T: IntoPatterns>(path: T) -> Resource {
-        let fref = Rc::new(RefCell::new(None));
+        let factory_ref = Rc::new(RefCell::new(None));
 
         Resource {
             routes: Vec::new(),
             rdef: path.patterns(),
             name: None,
-            endpoint: ResourceEndpoint::new(fref.clone()),
-            factory_ref: fref,
+            endpoint: ResourceEndpoint::new(Rc::clone(&factory_ref)),
+            factory_ref,
             guards: Vec::new(),
             app_data: None,
             default: boxed::factory(fn_service(|req: ServiceRequest| async {
diff --git a/actix-web/src/route.rs b/actix-web/src/route.rs
@@ -77,7 +77,7 @@ impl ServiceFactory<ServiceRequest> for Route {
 
     fn new_service(&self, _: ()) -> Self::Future {
         let fut = self.service.new_service(());
-        let guards = self.guards.clone();
+        let guards = Rc::clone(&self.guards);
 
         Box::pin(async move {
             let service = fut.await?;
diff --git a/actix-web/src/server.rs b/actix-web/src/server.rs
diff --git a/awc/Cargo.toml b/awc/Cargo.toml
diff --git a/awc/src/client/pool.rs b/awc/src/client/pool.rs
diff --git a/awc/src/frozen.rs b/awc/src/frozen.rs
diff --git a/awc/src/lib.rs b/awc/src/lib.rs
diff --git a/awc/src/middleware/redirect.rs b/awc/src/middleware/redirect.rs

Original file line number	Diff line number	Diff line change
`@@ -541,6 +541,6 @@ where`
`541`	`541`
`542`	`542`	`fn call(&self, (io, addr): (T, Option<net::SocketAddr>)) -> Self::Future {`
`543`	`543`	`let conn_data = OnConnectData::from_io(&io, self.on_connect_ext.as_deref());`
`544`		`- Dispatcher::new(io, self.flow.clone(), self.cfg.clone(), addr, conn_data)`
	`544`	`+ Dispatcher::new(io, Rc::clone(&self.flow), self.cfg.clone(), addr, conn_data)`
`545`	`545`	`}`
`546`	`546`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ impl<T: Head> ops::DerefMut for Message<T> {`
`66`	`66`
`67`	`67`	`impl<T: Head> Drop for Message<T> {`
`68`	`68`	`fn drop(&mut self) {`
`69`		`- T::with_pool(\|p\| p.release(self.head.clone()))`
	`69`	`+ T::with_pool(\|p\| p.release(Rc::clone(&self.head)))`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`